Allow to modify/extend search algorithm#724
Conversation
LordIdra
left a comment
There was a problem hiding this comment.
Just doing a second pass on this, how would you go about actually implementing different search logic for a locale? Surely we'd want to have that functionality as part of Rebar and not an addon which this seems to be tailored towards? Can the functionality not just be coded directly into the search page so that the search page screen behaves differently for some specific locales, instead of having per-locale pages?
I have done something about it. Take Chinese as an example, it's Pinyin lib has a size of 3.0MB, which occupies a considerable amount of space yet achieves a very minor function. |
I don't understand. How does that relate to the PR or the question? |
In my opinion, it's not worthwhile to import a huge prebuilt library into Rebar just to implement this single function. |
|
As far as I can tell this would allow external addons to return a different search page with different search rules based on locale. |
|
It does not seem like a good idea to require servers to install a separate addon to get proper search functionality in certain languages in a plugin that has per-client translation; that is not a good solution. Can we not in-house the logic? I don't understand quite why we need this library looking over the existing issue |
Closes #723