Skip to content

Allow to modify/extend search algorithm#724

Open
balugaq wants to merge 2 commits into
masterfrom
balugaq/search-extension
Open

Allow to modify/extend search algorithm#724
balugaq wants to merge 2 commits into
masterfrom
balugaq/search-extension

Conversation

@balugaq

@balugaq balugaq commented May 3, 2026

Copy link
Copy Markdown
Collaborator

Closes #723

@LordIdra LordIdra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just doing a second pass on this, how would you go about actually implementing different search logic for a locale? Surely we'd want to have that functionality as part of Rebar and not an addon which this seems to be tailored towards? Can the functionality not just be coded directly into the search page so that the search page screen behaves differently for some specific locales, instead of having per-locale pages?

@balugaq

balugaq commented May 15, 2026

Copy link
Copy Markdown
Collaborator Author

Just doing a second pass on this, how would you go about actually implementing different search logic for a locale? Surely we'd want to have that functionality as part of Rebar and not an addon which this seems to be tailored towards? Can the functionality not just be coded directly into the search page so that the search page screen behaves differently for some specific locales, instead of having per-locale pages?

I have done something about it. Take Chinese as an example, it's Pinyin lib has a size of 3.0MB, which occupies a considerable amount of space yet achieves a very minor function.

@balugaq balugaq requested a review from LordIdra May 15, 2026 12:11
@LordIdra

Copy link
Copy Markdown
Contributor

I have done something about it. Take Chinese as an example, it's Pinyin lib has a size of 3.0MB, which occupies a considerable amount of space yet achieves a very minor function.

I don't understand. How does that relate to the PR or the question?

@balugaq

balugaq commented May 23, 2026

Copy link
Copy Markdown
Collaborator Author

I have done something about it. Take Chinese as an example, it's Pinyin lib has a size of 3.0MB, which occupies a considerable amount of space yet achieves a very minor function.

I don't understand. How does that relate to the PR or the question?

In my opinion, it's not worthwhile to import a huge prebuilt library into Rebar just to implement this single function.
So add APIs for external plugins to implement the feature. Server owners can choose to install the supporting library based on whether relevant players exist on their servers.

@Seggan

Seggan commented May 23, 2026

Copy link
Copy Markdown
Member

As far as I can tell this would allow external addons to return a different search page with different search rules based on locale.

@LordIdra

Copy link
Copy Markdown
Contributor

It does not seem like a good idea to require servers to install a separate addon to get proper search functionality in certain languages in a plugin that has per-client translation; that is not a good solution. Can we not in-house the logic? I don't understand quite why we need this library looking over the existing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to modify/extend search algorithm

3 participants