Rename constraints param of DefaultIsolatedEnv.install

[layday]

Description

This is a vestige from a previous version where the constraints.txt file was incorrectly interpreted as a requirement list.

Changelog

• Added changelog fragment: docs/changelog/<pr_number>.<type>.rst
  • Types: feature, bugfix, doc, removal, misc
  • Example: 123.feature.rst containing Add custom backend support - by :user:`yourname`

Checklist

• Tests pass locally (tox)
• Code follows project style (tox -e fix)
• Type checks pass (tox -e type)
• Documentation builds (tox -e docs)

[gaborbernat]

Wouldn't this be a breaking change?

[layday]

Technically, yes. It’s why I’ve put it under the v2 milestone. I’m hoping to revamp the util module for a new major release; this can go in with it.

[henryiii]

I checked pyodide-build, it doesn't use this arg.

[gaborbernat]

I'm not sure if we need this, but if you strongly feel about this, we should take this moment to add it to the entire library and collect similar breaking changes so we can do one pass through it.

That being said, I want to hold on to this change until we cut a new release for version one of all the non-breaking changes we already have on the main and it's not released.

[layday]

I agree, that's why I've been filing some of these changes under v2. See above:

Technically, yes. It’s why I’ve put it under the v2 milestone. I’m hoping to revamp the util module for a new major release; this can go in with it.

[gaborbernat]

Can we keep this pull request draft until we cut the release of the latest main branch under version 1, then?

[layday]

Sure.