馃敡 build(type): replace mypy with pyrefly - #1168
Merged
Merged
Conversation
Maintainers reviewing pypa#1159 favored one checker and rejected ty. Pyrefly now checks the project and enforces 100% package type coverage in the existing tox environment. The configuration promotes the two diagnostics that caught omissions in the mutation test.
`strict` leaves most Pyrefly diagnostics at their default severity. With `all`, new diagnostics fail CI until maintainers resolve or disable them. Resolve the actionable findings and install `colorama` in the type environment. Keep two style diagnostics off because they reject 288 intentional uses; the override diagnostic would add a runtime `typing_extensions` dependency on Python 3.10.
gaborbernat
marked this pull request as ready for review
August 25, 2026 06:25
gaborbernat
enabled auto-merge (squash)
August 25, 2026 06:32
layday
requested changes
Aug 26, 2026
layday
left a comment
layday
left a comment
Member
There was a problem hiding this comment.
A couple of these were too verbose I thought, otherwise looks good.
Co-authored-by: layday <layday@protonmail.com>
Co-authored-by: layday <layday@protonmail.com>
layday
reviewed
Aug 26, 2026
Member
|
I'm okay with this but let's wait for Henry's input as well. |
layday
disabled auto-merge
August 27, 2026 20:45
layday
approved these changes
Aug 27, 2026
Contributor
Author
Sorry missed that, if Henry has anything to add happy to open follow-uyp PR. |
henryiii
pushed a commit
that referenced
this pull request
Sep 9, 2026
Co-authored-by: layday <layday@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1159 bundled three type checkers. Running all three in development and CI feels like overkill. I have kept this PR to switching from mypy to Pyrefly for the project and its public types as requested by @layday.