fix(env): do not use symlinks on Windows, matching stdlib venv - #1177
Closed
kishansaaai wants to merge 1 commit into
Closed
fix(env): do not use symlinks on Windows, matching stdlib venv#1177kishansaaai wants to merge 1 commit into
kishansaaai wants to merge 1 commit into
Conversation
kishansaaai
requested review from
gaborbernat,
henryiii and
layday
as code owners
September 4, 2026 14:43
Member
|
Duplicate of #1176. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1175
Description
In
build1.6.0, PR #1118 fixed the destination path in_fs_supports_symlink()(dest = f'{tmp_file}-b'->f'{tmp_file.name}-b'), which previously caused the probe to always fail on Windows. Consequently, on Windows systems with Developer Mode enabled (including GitHub Actions Windows runners),_fs_supports_symlink()began returningTrue.This caused
venv.EnvBuilder(symlinks=True)to be used on Windows. On Windows, symlinked Python executables (such as in Conda and standard Python installations) break runtime DLL resolution (e.g.ImportError: DLL load failed while importing _ctypes) because the Windows loader resolves dependent DLLs relative to the symlink executable inScripts/rather than the base installation directory. This caused Windows build failures across projects such as XGBoost, LightGBM, and PartCAD.In the standard library
venv,symlinksdefaults unconditionally toos.name != 'nt':The stdlib
venvnever probes symlink support on Windows. As noted by @henryiii in #1175:Changes
src/build/env.py, simplify_fs_supports_symlink()toreturn os.name != 'nt', matching stdlibvenv.tests/test_env.py, update tests to verify_fs_supports_symlink()returnsTruefor POSIX andFalsefor Windows (nt).docs/changelog/1175.bugfix.rst.