Skip to content

fix: honor _fresh installs with the uv installer #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
r3wretrhy wants to merge 1 commit into from
Closed

fix: honor _fresh installs with the uv installer #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog/1179.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Honor ``_fresh`` isolated installs when using the uv installer - by :user:`r3wretrhy`
7 changes: 6 additions & 1 deletion src/build/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,12 @@ def install_dependencies( # pragma: no cover -- uv tests are skipped on PyPy, c
if (verbosity := _ctx.verbosity) > 1:
cmd += [f'-{"v" * min(2, verbosity - 1)}']

cmd += ['install', *requirements, '--python', self.python_executable]
cmd += ['install']
if _fresh:
# Match pip's ``--ignore-installed`` so CLI / project_wheel_metadata
# ``_fresh=True`` (preset PYTHONPATH) actually reinstalls into the env.
cmd += ['--reinstall']
cmd += [*requirements, '--python', self.python_executable]

if constraints_txt_path:
cmd += ['-c', str(constraints_txt_path)]
Expand Down
1 change: 1 addition & 0 deletions tests/test_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ def test_uv_impl_install_cmd_well_formed( # pragma: no cover -- uv tests are sk
'pip',
*(['-vv' if verbosity > 2 else '-v'] if verbosity > 1 else []),
'install',
*(['--reinstall'] if fresh else []),
'some',
'requirements',
'--python',
Expand Down
Loading