Open
Conversation
Member
|
Thanks @lklivingstone for the PR, be aware review capacity is extremely limited at the moment, so it may take a bit for a maintainer to get to your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13406
Summary
When running
pip install --upgrade, if the package index cannot be accessed (e.g. due to invalid credentials or network errors) and the package is already installed, pip may incorrectly report “Requirement already satisfied” and exit with status code 0.This change tracks index access failures during index page retrieval and records them on the PipSession. During candidate generation in the resolver, pip checks this flag and raises an InstallationError if the index could not be accessed and index candidates are required.
This ensures
pip install --upgradefails with a non-zero exit code when pip cannot access the configured package index to determine available versions.Logs
Correct Password
Incorrect Password