Skip to content

initiate deprecation smoothing and tabular modules#494

Open
jGaboardi wants to merge 3 commits into
pysal:mainfrom
jGaboardi:GH464_deprecate_smoothing_tabular
Open

initiate deprecation smoothing and tabular modules#494
jGaboardi wants to merge 3 commits into
pysal:mainfrom
jGaboardi:GH464_deprecate_smoothing_tabular

Conversation

@jGaboardi

Copy link
Copy Markdown
Member

@jGaboardi jGaboardi self-assigned this May 10, 2026
@codecov

codecov Bot commented May 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.0%. Comparing base (415d226) to head (855d0cf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #494     +/-   ##
=======================================
+ Coverage   85.8%   86.0%   +0.1%     
=======================================
  Files         27      27             
  Lines       3625    3660     +35     
=======================================
+ Hits        3112    3147     +35     
  Misses       513     513             
Files with missing lines Coverage Δ
esda/smoothing.py 92.7% <100.0%> (+0.8%) ⬆️
esda/tabular.py 65.7% <100.0%> (+5.7%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjsrey sjsrey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

But, I think we should reconsider the deprecation of smoothing as I've now seen it being used in the wild. Perhaps next dev meeting we can have a discussion?
xref #464

@jGaboardi

Copy link
Copy Markdown
Member Author

Agreed. Just wanted to keep this branch up to date, in case we change that decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants