Skip to content

TST: matplotlib 3.11 compatibility#313

Open
martinfleis wants to merge 3 commits into
pysal:mainfrom
martinfleis:mpl311
Open

TST: matplotlib 3.11 compatibility#313
martinfleis wants to merge 3 commits into
pysal:mainfrom
martinfleis:mpl311

Conversation

@martinfleis

Copy link
Copy Markdown
Member

No description provided.

@martinfleis

Copy link
Copy Markdown
Member Author

This fixes failures with stable. Seems something similar is happening on dev but these image comparisons are pain to do by version...

@jGaboardi

Copy link
Copy Markdown
Member

shall we simply skip the image comparisons in dev? They generally always seem to be a bit different due to the installing from PyPI in dev vs. conda-forge for all other envs.

@martinfleis

Copy link
Copy Markdown
Member Author

@jGaboardi how do I do that? I'd need to re-work the test action to set env variable when using dev envs, no?

@jGaboardi

Copy link
Copy Markdown
Member

I will carve out sometime to fix later this evening. Please bug me tomorrow if I haven't by then.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.1%. Comparing base (18c8baf) to head (413903f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #313     +/-   ##
=======================================
- Coverage   90.2%   90.1%   -0.1%     
=======================================
  Files         11      11             
  Lines       1308    1308             
=======================================
- Hits        1180    1179      -1     
- Misses       128     129      +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi jGaboardi added the CI label Jun 26, 2026
@jGaboardi jGaboardi requested a review from sjsrey June 26, 2026 03:02
@jGaboardi

Copy link
Copy Markdown
Member

@martinfleis -- tagging you for review

orientation="horizontal",
)

@pytest.mark.skipif(GPD_113_dev, reason="Fixed in GeoPandas dev as of [2026/06]")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we skipping this? Also, the plotting change in GeoPandas is targeting 1.2, there will be 1.1.4 release without it, so the condition might break.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping because the test fails on in bleeding edge geopandas, since no warnings are thrown and I thought that logic path was going in geopandas anyway -- but perhaps I misunderstood. It was late and I wasn't sure if I wanted to add in the dev environment logic specifically only for this. I can probably figure out some other "clever" way of handling if we aren't comfortable with this "solution" (quotes are very on purpose).

Other than this specific thing, how do you find this testing update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants