TST: matplotlib 3.11 compatibility#313
Conversation
|
This fixes failures with stable. Seems something similar is happening on dev but these image comparisons are pain to do by version... |
|
shall we simply skip the image comparisons in |
|
@jGaboardi how do I do that? I'd need to re-work the test action to set env variable when using dev envs, no? |
|
I will carve out sometime to fix later this evening. Please bug me tomorrow if I haven't by then. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
- Coverage 90.2% 90.1% -0.1%
=======================================
Files 11 11
Lines 1308 1308
=======================================
- Hits 1180 1179 -1
- Misses 128 129 +1 🚀 New features to boost your workflow:
|
|
@martinfleis -- tagging you for review |
| orientation="horizontal", | ||
| ) | ||
|
|
||
| @pytest.mark.skipif(GPD_113_dev, reason="Fixed in GeoPandas dev as of [2026/06]") |
There was a problem hiding this comment.
why are we skipping this? Also, the plotting change in GeoPandas is targeting 1.2, there will be 1.1.4 release without it, so the condition might break.
There was a problem hiding this comment.
Skipping because the test fails on in bleeding edge geopandas, since no warnings are thrown and I thought that logic path was going in geopandas anyway -- but perhaps I misunderstood. It was late and I wasn't sure if I wanted to add in the dev environment logic specifically only for this. I can probably figure out some other "clever" way of handling if we aren't comfortable with this "solution" (quotes are very on purpose).
Other than this specific thing, how do you find this testing update?
No description provided.