refactor: Transform the comparator in 'assertion' into generators#14521
Merged
Pierre-Sassoulas merged 4 commits intoMay 26, 2026
Conversation
Pierre-Sassoulas
added
the
skip news
| highlighter, | ||
| verbose, | ||
| assertion_text_diff_style, | ||
| explanation = list( |
Member
Author
There was a problem hiding this comment.
Had to call list at some point to keep the scope tight, but it could be refactored further later.
bluetech
approved these changes
May 25, 2026
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Nice!
Would be good to also convert set/iterable/approx/any for consistency, but can be done later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor prior to doing #13762 as suggested in #13762 (comment) and #13762 (comment)