Skip to content

Fix Learner2D state rollback in BalancingLearner ask(tell_pending=False) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basnijholt merged 3 commits into from
Jun 10, 2026
+15 −3
Merged

Fix Learner2D state rollback in BalancingLearner ask(tell_pending=False) #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abecea7
Initial plan
Copilot Jun 10, 2026
0c8774a
Fix Learner2D restore snapshot mutation in balancing asks
Copilot Jun 10, 2026
5654448
Use shallow copies instead of deepcopy in Learner2D.__getstate__
basnijholt Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adaptive/learner/learner2D.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,8 +897,8 @@ def __getstate__(self):
cloudpickle.dumps(self.function),
self.bounds,
self.loss_per_triangle,
self._stack,
self._get_data(),
self._stack.copy(),
self._get_data().copy(),
)

def __setstate__(self, state):
Expand Down
14 changes: 13 additions & 1 deletion adaptive/tests/test_balancing_learner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import pytest

from adaptive.learner import BalancingLearner, Learner1D
from adaptive.learner import BalancingLearner, Learner1D, Learner2D
from adaptive.runner import simple

strategies = ["loss", "loss_improvements", "npoints", "cycle"]
Expand Down Expand Up @@ -51,6 +51,18 @@ def test_ask_0(strategy):
assert len(points) == 0


def test_ask_without_pending_restores_learner2d_state():
learner = Learner2D(lambda xy: xy[0] + xy[1], bounds=((-1, 1), (-1, 1)))
initial_stack = list(learner._stack.items())
initial_data = learner.data.copy()

balancing_learner = BalancingLearner([learner])
balancing_learner.ask(1, tell_pending=False)

assert list(learner._stack.items()) == initial_stack
assert learner.data == initial_data


@pytest.mark.parametrize(
"strategy, goal_type, goal",
[
Expand Down
Loading