Skip to content

Accept sets and reject bytes as predicate values - #169

Merged
RazerM merged 1 commit into
mainfrom
feature/predicate-values
Aug 23, 2026
Merged

RazerM merged 1 commit into
mainfrom
feature/predicate-values

Conversation

@RazerM

@RazerM RazerM commented Aug 22, 2026

Copy link
Copy Markdown
Member

Sets and frozensets fell through to str(), silently sending values like
'{25544, 34602}' in the query URL where a list sends '25544,34602'.
bytes are registered Sequences, so they were serialised as comma-joined
integer ordinals. Join Set values like Sequences, and raise TypeError
for bytes-like values instead of building a garbage query.

@RazerM RazerM changed the title Accept sets and reject bytes-like predicate values Accept sets and reject bytes as predicate values Aug 22, 2026
@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.35%. Comparing base (168de31) to head (1ea2bbe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   96.33%   96.35%   +0.01%     
==========================================
  Files           7        7              
  Lines        1147     1153       +6     
  Branches      129      130       +1     
==========================================
+ Hits         1105     1111       +6     
  Misses         25       25              
  Partials       17       17              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RazerM
RazerM force-pushed the feature/predicate-values branch from 1444669 to d7408c8 Compare August 22, 2026 21:27
Sets and frozensets fell through to str(), silently sending values like
'{25544, 34602}' in the query URL where a list sends '25544,34602'.
bytes are registered Sequences, so they were serialised as comma-joined
integer ordinals. Join Set values like Sequences, and raise TypeError
for bytes-like values instead of building a garbage query.
@RazerM
RazerM force-pushed the feature/predicate-values branch from d7408c8 to 1ea2bbe Compare August 23, 2026 13:09
@RazerM
RazerM merged commit d22e259 into main Aug 23, 2026
11 checks passed
@RazerM
RazerM deleted the feature/predicate-values branch August 23, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant