Add missing arguments to run_process#3212
Merged
A5rocks merged 8 commits intopython-trio:mainfrom Mar 13, 2025
Merged
Conversation
A5rocks
commented
Feb 16, 2025
f050eba to
b81444d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
================================================
Coverage 100.00000% 100.00000%
================================================
Files 124 124
Lines 18764 18990 +226
Branches 1269 1302 +33
================================================
+ Hits 18764 18990 +226
🚀 New features to boost your workflow:
|
d3e7789 to
e377c32
Compare
jakkdl
approved these changes
Feb 19, 2025
Member
There was a problem hiding this comment.
I haven't looked terribly close at the arguments, but seems fine at a glance.
In an ideal world it'd maybe be nice to have tests.. but it sounds messy to write something that validates against typeshed signatures and handles version/platform differences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3183
I tried out TypedDict here like @decorator-factory recommended and it's nicer, though it's explicitly trading off user experience:
I think it's worth it? I doubt people are looking at overloads for the defaults to things.
I still need to add type tests.