Add aiofiles.threadpool.wrap to type stubs#15626
Open
qorexdev wants to merge 1 commit intopython:mainfrom
Open
Add aiofiles.threadpool.wrap to type stubs#15626qorexdev wants to merge 1 commit intopython:mainfrom
qorexdev wants to merge 1 commit intopython:mainfrom
Conversation
Expose the singledispatch `wrap` function in aiofiles.threadpool stubs. This was missing, causing mypy attr-defined errors when accessing threadpool.wrap or calling wrap.register(). Closes python#15624
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiofiles.threadpool.wrapis afunctools.singledispatchfunction used to register custom file types for async wrapping. It's currently missing from the stubs, so accessingthreadpool.wrapor callingwrap.register(...)gives a mypyattr-definederror.Added it as
_SingleDispatchCallable[Any]which matches the runtime type and gives users access to.register()and.dispatch().Closes #15624