Skip to content

Move LlmConfig to extension/llm#11872

Merged
facebook-github-bot merged 1 commit into
mainfrom
jz/move-llm-config-2
Jun 26, 2025
Merged

Move LlmConfig to extension/llm#11872
facebook-github-bot merged 1 commit into
mainfrom
jz/move-llm-config-2

Conversation

@jackzhxng

@jackzhxng jackzhxng commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Moves LlmConfig from examples/models/llama/config to extension/llm/export/config

@pytorch-bot

pytorch-bot Bot commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11872

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit d865320 with merge base a627be6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2025
@jackzhxng jackzhxng added the release notes: none Do not include this in the release notes label Jun 24, 2025
@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch from 44b5eac to ffc8453 Compare June 24, 2025 17:34
@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch 4 times, most recently from 718304a to aabb6fa Compare June 25, 2025 22:31
@facebook-github-bot

facebook-github-bot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch 3 times, most recently from bc9756c to 9a8282d Compare June 26, 2025 00:35
@facebook-github-bot

facebook-github-bot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D77338897

jackzhxng added a commit that referenced this pull request Jun 26, 2025
@jackzhxng @facebook-github-bot
Move LlmConfig to extension/llm (#11872)
c086f42 
Summary:
Moves `LlmConfig` from `examples/models/llama/config` to `extension/llm/export/config`

Pull Request resolved: #11872

Differential Revision: D77338897

Pulled By: jackzhxng
@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch from 9a8282d to c086f42 Compare June 26, 2025 01:46
digantdesai
digantdesai reviewed Jun 26, 2025
View reviewed changes

@digantdesai digantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is just a mechanical move? i.e. no functional change otherwise?

Also I assume moving this in extensions/llm is been through a review of sorts?

@jackzhxng @facebook-github-bot
Move LlmConfig to extension/llm (#11872)
d865320 
Summary:
Moves `LlmConfig` from `examples/models/llama/config` to `extension/llm/export/config`

Pull Request resolved: #11872

Differential Revision: D77338897

Pulled By: jackzhxng
@facebook-github-bot

facebook-github-bot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D77338897

@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch from c086f42 to d865320 Compare June 26, 2025 17:06
@facebook-github-bot facebook-github-bot merged commit 53dff25 into main Jun 26, 2025
200 of 203 checks passed
@facebook-github-bot facebook-github-bot deleted the jz/move-llm-config-2 branch June 26, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai left review comments

@mergennachin mergennachin mergennachin approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@swolchok swolchok Awaiting requested review from swolchok

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

+1 more reviewer

@lucylq lucylq lucylq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jackzhxng @facebook-github-bot @digantdesai @mergennachin @lucylq