Skip to content

Move transformer base definition to extension/llm#11917

Closed
jackzhxng wants to merge 12 commits into
mainfrom
jz/move-modeling
Closed

Move transformer base definition to extension/llm#11917
jackzhxng wants to merge 12 commits into
mainfrom
jz/move-modeling

Conversation

@jackzhxng

Copy link
Copy Markdown
Contributor

No description provided.

@pytorch-bot

pytorch-bot Bot commented Jun 24, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11917

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 47 New Failures

As of commit f65b648 with merge base 77a7ace (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2025
@jackzhxng jackzhxng changed the base branch from main to jz/move-llm-config-2 June 24, 2025 17:43
@jackzhxng jackzhxng added the release notes: none Do not include this in the release notes label Jun 24, 2025
@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch from 718304a to aabb6fa Compare June 25, 2025 22:31
@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch from aabb6fa to 7212a18 Compare June 25, 2025 23:09
@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch from 7212a18 to bc9756c Compare June 25, 2025 23:12
@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch from bc9756c to 9a8282d Compare June 26, 2025 00:35

@digantdesai digantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it mainly mechanical move? I see bunch of CI failures, also added trunk tag to make sure we don't regress silently on other jobs.

@@ -0,0 +1,308 @@
# @lint-ignore-every LICENSELINT

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use git mv to preserve the history better? I saw the import error message update, perhaps that's why you didn't do it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try, I just forgot to do git mv this time

@jackzhxng jackzhxng force-pushed the jz/move-llm-config-2 branch from c086f42 to d865320 Compare June 26, 2025 17:06
Base automatically changed from jz/move-llm-config-2 to main June 26, 2025 23:02
@jackzhxng jackzhxng requested a review from mcr229 as a code owner June 27, 2025 03:48

@mergennachin mergennachin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not make the extension/llm/modeling/text_decoder/decoder_model.py move. There are too many examples and meta specific stuff there... let's keep it in examples

@mergennachin

Copy link
Copy Markdown
Contributor

Why did you not move llama_transformer.py to extension inside?

@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot added the Stale PRs inactive for over 60 days label Sep 3, 2025
@jackzhxng jackzhxng closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes Stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants