Skip to content

Arm backend: Rename test_arm_baremetal.sh to test_arm_backend.sh#19665

Merged
zingo merged 5 commits into
pytorch:mainfrom
zingo:Arm-backend-Rename-test_arm_baremetal.sh-to-test_arm_backend.sh
May 19, 2026
Merged

Arm backend: Rename test_arm_baremetal.sh to test_arm_backend.sh#19665
zingo merged 5 commits into
pytorch:mainfrom
zingo:Arm-backend-Rename-test_arm_baremetal.sh-to-test_arm_backend.sh

Conversation

@zingo

@zingo zingo commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Rename tests script as it tests both Arm Ethos-U and VGF backend

Test plan

This script is tested by the GitHub jobs

cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: I172d78c3c97fddceefafec36dfc23d2e62798665
@zingo zingo requested a review from digantdesai as a code owner May 19, 2026 11:18
Copilot AI review requested due to automatic review settings May 19, 2026 11:18
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels May 19, 2026
@pytorch-bot

pytorch-bot Bot commented May 19, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19665

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 7 Pending, 1 Unrelated Failure

As of commit 68abe96 with merge base 5eb8492 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2026
@github-actions github-actions Bot added the module: arm Issues related to arm backend label May 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Arm backend CI/test entrypoint by switching references from test_arm_baremetal.sh to a newly added test_arm_backend.sh, aligning the naming with the script’s actual coverage (Ethos-U + VGF/VKML).

Changes:

  • Add backends/arm/test/test_arm_backend.sh and update CI workflows to invoke it.
  • Update Arm backend documentation to reference test_arm_backend.sh.
  • Rename workflow matrix key from test_arm_baremetal to test_arm_backend.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.

File Description
backends/arm/test/test_arm_backend.sh Adds the newly named Arm backend test runner script used by CI.
backends/arm/README.md Updates testing docs to reference the new script name and commands.
.github/workflows/trunk.yml Updates trunk CI to use the new matrix key and script path.
.github/workflows/pull.yml Updates PR CI to use the new matrix key and script path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backends/arm/test/test_arm_backend.sh
Comment thread backends/arm/test/test_arm_backend.sh
Comment thread backends/arm/test/test_arm_backend.sh Outdated
Comment thread backends/arm/test/test_arm_backend.sh Outdated
Comment thread backends/arm/README.md Outdated
Comment thread backends/arm/README.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 11:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

backends/arm/test/test_arm_backend.sh:72

  • In all(), the generated commands are prefixed with $0, but the script changes directories early on. If invoked via a relative path (e.g. ./test_arm_backend.sh all from backends/arm/test), $0 won't be valid from the new working directory and the sub-shell will fail to execute the tests. Consider prefixing with an absolute script path (from script_dir/BASH_SOURCE[0]) instead of $0.
    # That is executed
    echo "${TEST_SUITE_NAME}: Run all tests"
    grep "^test_" backends/arm/test/test_arm_backend.sh | sed 's/([^)]*)[[:space:]]*{*//g' | sed "s|^|$0 |" | sh
    echo "${TEST_SUITE_NAME}: PASS"

Comment thread backends/arm/test/test_arm_backend.sh
Comment thread backends/arm/README.md
Comment thread backends/arm/README.md Outdated
Comment thread backends/arm/README.md
Comment thread backends/arm/test/test_arm_backend.sh Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 11:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Comment thread backends/arm/test/test_arm_backend.sh Outdated
Comment thread backends/arm/test/test_arm_backend.sh
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 11:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Comment thread backends/arm/test/test_arm_backend.sh Outdated
Comment thread backends/arm/test/test_arm_backend.sh
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 12:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

@zingo zingo merged commit a4c3897 into pytorch:main May 19, 2026
447 of 449 checks passed
@zingo zingo deleted the Arm-backend-Rename-test_arm_baremetal.sh-to-test_arm_backend.sh branch May 20, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants