Arm backend: Rename test_arm_baremetal.sh to test_arm_backend.sh#19665
Conversation
Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com> Change-Id: I172d78c3c97fddceefafec36dfc23d2e62798665
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19665
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 7 Pending, 1 Unrelated FailureAs of commit 68abe96 with merge base 5eb8492 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Arm backend CI/test entrypoint by switching references from test_arm_baremetal.sh to a newly added test_arm_backend.sh, aligning the naming with the script’s actual coverage (Ethos-U + VGF/VKML).
Changes:
- Add
backends/arm/test/test_arm_backend.shand update CI workflows to invoke it. - Update Arm backend documentation to reference
test_arm_backend.sh. - Rename workflow matrix key from
test_arm_baremetaltotest_arm_backend.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| backends/arm/test/test_arm_backend.sh | Adds the newly named Arm backend test runner script used by CI. |
| backends/arm/README.md | Updates testing docs to reference the new script name and commands. |
| .github/workflows/trunk.yml | Updates trunk CI to use the new matrix key and script path. |
| .github/workflows/pull.yml | Updates PR CI to use the new matrix key and script path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
backends/arm/test/test_arm_backend.sh:72
- In
all(), the generated commands are prefixed with$0, but the script changes directories early on. If invoked via a relative path (e.g../test_arm_backend.sh allfrombackends/arm/test),$0won't be valid from the new working directory and the sub-shell will fail to execute the tests. Consider prefixing with an absolute script path (fromscript_dir/BASH_SOURCE[0]) instead of$0.
# That is executed
echo "${TEST_SUITE_NAME}: Run all tests"
grep "^test_" backends/arm/test/test_arm_backend.sh | sed 's/([^)]*)[[:space:]]*{*//g' | sed "s|^|$0 |" | sh
echo "${TEST_SUITE_NAME}: PASS"
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Rename tests script as it tests both Arm Ethos-U and VGF backend
Test plan
This script is tested by the GitHub jobs
cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani