Repair etvk.vma_dep=instantiated to share VMA via 3.2.0#20225
Merged
Conversation
Summary: Fixes the ExecuTorch Vulkan backend's `etvk.vma_dep=instantiated` mode so the backend links a single, shared VulkanMemoryAllocator (VMA) instead of instantiating its own. This is the prerequisite that lets a binary link both ET Vulkan and another VMA consumer (e.g. IGL/compphoto) without an `ld.lld: duplicate symbol: Vma*` collision. Changes (both `fbcode` and `xplat` mirrors): 1. `backends/vulkan/targets.bzl`: repair the `etvk.vma_dep=instantiated` path, which pointed at `//third-party/VulkanMemoryAllocator/3.0.1:VulkanMemoryAllocatorInstantiated` — a package that no longer exists at HEAD (only `3.2.0` remains), so the mode was broken for everyone. Repoint it to `3.2.0:VulkanMemoryAllocatorInstantiated`, the same target IGL/compphoto already use, so VMA is linked exactly once. 2. `backends/vulkan/runtime/vk_api/memory/vma_api.h`: align the `ETVK_USE_META_VMA` branch `VMA_VULKAN_VERSION` from `1002000` to `1003000` to match the 3.2.0 instantiated lib's config (`vk_mem_alloc_instantiated.h`) so struct layouts agree across translation units and the pre-instantiated static lib (ABI safety). Both changes only affect the opt-in `etvk.vma_dep=instantiated` mode (which was already broken/unused), so default `xplat` builds and all other ET consumers are byte-for-byte unchanged. Differential Revision: D108337179
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@blood-orange has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108337179. |
blood-orange
added
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20225
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 43 PendingAs of commit b292c2f with merge base 2302c25 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
SS-JIA
approved these changes
Jun 11, 2026
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes the ExecuTorch Vulkan backend's
etvk.vma_dep=instantiatedmode so the backend links a single, shared VulkanMemoryAllocator (VMA) instead of instantiating its own. This is the prerequisite that lets a binary link both ET Vulkan and another VMA consumer (e.g. IGL/compphoto) without anld.lld: duplicate symbol: Vma*collision.Changes (both
fbcodeandxplatmirrors):backends/vulkan/targets.bzl: repair theetvk.vma_dep=instantiatedpath, which pointed at//third-party/VulkanMemoryAllocator/3.0.1:VulkanMemoryAllocatorInstantiated— a package that no longer exists at HEAD (only3.2.0remains), so the mode was broken for everyone. Repoint it to3.2.0:VulkanMemoryAllocatorInstantiated, the same target IGL/compphoto already use, so VMA is linked exactly once.backends/vulkan/runtime/vk_api/memory/vma_api.h: align theETVK_USE_META_VMAbranchVMA_VULKAN_VERSIONfrom1002000to1003000to match the 3.2.0 instantiated lib's config (vk_mem_alloc_instantiated.h) so struct layouts agree across translation units and the pre-instantiated static lib (ABI safety).Both changes only affect the opt-in
etvk.vma_dep=instantiatedmode (which was already broken/unused), so defaultxplatbuilds and all other ET consumers are byte-for-byte unchanged.Differential Revision: D108337179