Skip to content

Repair etvk.vma_dep=instantiated to share VMA via 3.2.0 #20225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blood-orange merged 1 commit into from
Jun 11, 2026
+5 −2
Merged

Repair etvk.vma_dep=instantiated to share VMA via 3.2.0 #20225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backends/vulkan/runtime/vk_api/memory/vma_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@
#undef VMA_DYNAMIC_VULKAN_FUNCTIONS
#define VMA_STATIC_VULKAN_FUNCTIONS 0
#define VMA_DYNAMIC_VULKAN_FUNCTIONS 1
#define VMA_VULKAN_VERSION 1002000
// Must match the 3.2.0 VulkanMemoryAllocatorInstantiated config
// (vk_mem_alloc_instantiated.h) so struct layouts agree across translation
// units and the pre-instantiated static lib.
#define VMA_VULKAN_VERSION 1003000

#ifdef __clang__
#pragma clang diagnostic push
Expand Down
2 changes: 1 addition & 1 deletion backends/vulkan/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def define_common_targets(is_fbcode = False):

if vma_dep == "instantiated":
VK_API_DEPS = [
"fbsource//third-party/VulkanMemoryAllocator/3.0.1:VulkanMemoryAllocatorInstantiated",
"fbsource//third-party/VulkanMemoryAllocator/3.2.0:VulkanMemoryAllocatorInstantiated",
]
else:
VK_API_DEPS = [
Expand Down
Loading