Skip to content

Fix Samsung backend PassManager import broken by #20025#20228

Merged
shoumikhin merged 1 commit into
mainfrom
fix-samsung-passmanager-import
Jun 12, 2026
Merged

Fix Samsung backend PassManager import broken by #20025#20228
shoumikhin merged 1 commit into
mainfrom
fix-samsung-passmanager-import

Conversation

@shoumikhin

Copy link
Copy Markdown
Contributor

#20025 ("Arm backend: Migrate pass manager to exported program") changed exir/passes/__init__.py to re-export ExportedProgramPassManager instead of PassManager. The Samsung backend still imports PassManager from executorch.exir.passes, so every Samsung model export now fails at import:

ImportError: cannot import name 'PassManager' from 'executorch.exir.passes'

This has made test-samsung-quantmodels-linux red on every main commit since 2026-06-11 14:52 UTC and is blocking viable/strict promotion (stale ~31h).

The legacy PassManager class still exists in executorch.exir.pass_manager. The Samsung backend runs passes on a GraphModule (enn_preprocess_passes(edge_program.graph_module)), which is exactly what the legacy PassManager is for, not the new ExportedProgramPassManager. This repoints the import to its canonical module and restores the previous behavior.

cc @usamahz

Repoint the import to executorch.exir.pass_manager (its canonical module).
Copilot AI review requested due to automatic review settings June 12, 2026 00:01
@pytorch-bot

pytorch-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20228

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1672975 with merge base b47e588 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Samsung backend import regression caused by #20025 changing executorch.exir.passes to no longer re-export the legacy PassManager. It restores Samsung export functionality by importing PassManager from its canonical module (executorch.exir.pass_manager), preserving the existing GraphModule-based pass pipeline behavior.

Changes:

  • Update Samsung backend to import PassManager from executorch.exir.pass_manager instead of executorch.exir.passes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shoumikhin shoumikhin merged commit 7282106 into main Jun 12, 2026
188 of 190 checks passed
@shoumikhin shoumikhin deleted the fix-samsung-passmanager-import branch June 12, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants