[Pallas] Ordered carry store for jagged row tiles#2719
Open
thcmbs wants to merge 1 commit into
Open
Conversation
thcmbs
added a commit
that referenced
this pull request
Jun 8, 2026
stack-info: PR: #2719, branch: thcmbs/stack/3
thcmbs
added a commit
that referenced
this pull request
Jun 8, 2026
stack-info: PR: #2719, branch: thcmbs/stack/3
This was referenced Jun 8, 2026
thcmbs
added a commit
to thcmbs/helion
that referenced
this pull request
Jun 8, 2026
stack-info: PR: pytorch#2719, branch: thcmbs/stack/3
364969f to
a054371
Compare
thcmbs
added a commit
that referenced
this pull request
Jun 8, 2026
stack-info: PR: #2719, branch: thcmbs/stack/3
thcmbs
added a commit
to thcmbs/helion
that referenced
this pull request
Jun 11, 2026
stack-info: PR: pytorch#2719, branch: thcmbs/stack/3
thcmbs
added a commit
that referenced
this pull request
Jun 11, 2026
stack-info: PR: #2719, branch: thcmbs/stack/3
thcmbs
added a commit
that referenced
this pull request
Jun 11, 2026
stack-info: PR: #2719, branch: thcmbs/stack/3
thcmbs
added a commit
that referenced
this pull request
Jun 11, 2026
stack-info: PR: #2719, branch: thcmbs/stack/3
thcmbs
added a commit
that referenced
this pull request
Jun 11, 2026
stack-info: PR: #2719, branch: thcmbs/stack/3
stack-info: PR: #2719, branch: thcmbs/stack/3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
We implement the carry in this PR. When a group's first or last block isn't aligned, its window overlaps the neighbour on one row. A grid-level scratch stitches it: fold the previous group's partial into the first block (
out[:S] += carry), save this group's partial from the last block (carry = out[-S:]). Saving the folded value keeps it cumulative, so several tiny groups in one row compose. Relies on groups running in order, which the grid guarantees.Does: jagged matmul correct on f32 and bf16 across the tested layouts (shared boundaries, tiny/odd groups, block bigger than a group, multiple column tiles), checked against a per-group reference. A plain map-axis store (
out[st] = 2 * jagged[st]) uses the same path.Gaps (I left TODOs to keep track of them and iterate with follow ups):
L >= blocktested);