[CRCR] Fix nightly dashboard partial rows at time-window boundary - #8695
Open
subinz1 wants to merge 2 commits into
Open
[CRCR] Fix nightly dashboard partial rows at time-window boundary#8695subinz1 wants to merge 2 commits into
subinz1 wants to merge 2 commits into
Conversation
The nightly dashboard query filtered by per-job started_at, which
caused partial SHA rows when a pipeline's jobs start at different
times. For example, with a 7-day window and a nightly run where the
build job starts first and test jobs start 1-2 hours later, the build
job would age out of the window while tests remained — producing a
row with missing cells ("no signal") for the older jobs.
Switch to run-level filtering: identify eligible run_ids (where at
least one job started within the window), then include ALL jobs from
those runs. This ensures complete nightly rows at the boundary.
Ref #8691
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
3 tasks
subinz1
marked this pull request as ready for review
September 1, 2026 14:19
subinz1
changed the title
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "no signal" cells appearing on the last row of the nightly dashboard, and partially addresses the jobs count discrepancy reported in #8691.
Root cause: The nightly dashboard query filtered by per-job
started_at > now() - INTERVAL {days} DAY. In a nightly pipeline, jobs execute sequentially — build starts first, then tests start 1-2 hours later. When the time window clips through a run at the boundary, earlier-starting jobs (build) age out while later-starting jobs (tests) remain. This produces partial SHA rows with empty cells for the disappeared jobs.Fix: Switch to run-level filtering using a CTE. First, identify
eligible_runswhere at least one job started within the window. Then include ALL jobs from those runs, regardless of individualstarted_at. This ensures complete nightly rows at the boundary — no more jobs disappearing one-by-one from the last row.Before:
After:
Ref #8691
Test plan
Closes #8691 (partial)
Fixes #8691 (partial — companion: #8696)