Improve error handling and message of lowering helper functions.#9722
Merged
Conversation
zhanyong-wan
requested changes
Dec 2, 2025
ysiraichi
force-pushed
the
ysiraichi/better-error-lower-helpers
branch
from
e310dc3 to
f5b654b
Compare
ysiraichi
force-pushed
the
ysiraichi/better-error-lower-helpers
branch
from
f5b654b to
1528223
Compare
zhanyong-wan
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the error handling and error message of some lowering helper functions found in
helpers.{h,cpp}C++ files.Key Changes:
Safe*versions of the functions:FlattenDynamicReshapeGetDynamicReshapeInfoCheckAtMostOneDynamicDimension()function, a version ofGetDynamicDimensionwith improved error handling and messagesshapeparameter fromSafeFlatten()