Skip to content

Fix composite pass missing captured values in ops with nested regions #9760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mstojkovicTT wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix composite pass missing captured values in ops with nested regions #9760

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42877e4
nested regions fix
mstojkovicTT Mar 30, 2026
92928cb
clang-format
mstojkovicTT Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions torch_xla/csrc/runtime/stablehlo_composite_helper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "mlir/Analysis/TopologicalSortUtils.h"
#include "mlir/IR/IRMapping.h"
#include "mlir/Support/LogicalResult.h"
#include "mlir/Transforms/RegionUtils.h"
#include "single_include/nlohmann/json.hpp"
#include "stablehlo/dialect/StablehloOps.h"

Expand Down Expand Up @@ -418,6 +419,23 @@ class BuildStableHLOCompositePass : public mlir::OperationPass<mlir::ModuleOp> {
processing.push_back(def_op);
}
}
// Also collect values used inside nested regions (e.g., reduce body)
// that are defined in the parent function. These are not captured by
// getOperands() but need to be included in the composite.
for (mlir::Region& region : curr_op->getRegions()) {
llvm::SetVector<mlir::Value> captured;
mlir::getUsedValuesDefinedAbove(region, region, captured);
for (mlir::Value value : captured) {
mlir::Operation* def_op = value.getDefiningOp();
if (def_op == nullptr) {
arg_pos_setvec.insert({value, std::numeric_limits<int64_t>::max()});
} else if (llvm::isa<mlir::stablehlo::ConstantOp>(def_op)) {
impl_ops_setvec.insert(def_op);
} else {
processing.push_back(def_op);
}
}
}
}
// Sorts all ops within the boundary by their line numbers in the input
// MLIR. The ops will be duplicated to the impl function following this
Expand Down
Loading