Redact internal emails from tests and add a CI guard - #14
Merged
Conversation
The public repo had real @crate.io addresses in test fixtures (tests/test_excel_export.py: two real addresses plus an x@crate.io placeholder). Replace them with RFC 2606 example.com placeholders. Add a CI workflow that fails if any tracked file (outside .github/) contains an @crate.io address, so real addresses can't reappear in test data or fixtures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The public repo contained real
@crate.ioemail addresses in test fixtures. This replaces them with RFC 2606example.complaceholders and adds a CI guard so they can't reappear.tests/test_excel_export.py: two real addresses →engineer-a@example.com/engineer-b@example.com; thex@crate.ioplaceholder →x@example.com..github/workflows/no-internal-emails.yml: fails the build if any tracked file (outside.github/) contains an@crate.ioaddress.Companion cleanup already applied outside this PR: the PR #13 description was edited to anonymize the four engineer addresses, and the coverage-gap test fixtures (
tests/test_coverage_gaps.py, on the #13 branch) were switched toexample.com. Not addressed here (by decision): the addresses remaining in existing git history — no history rewrite.Testing
uv run --extra test pytest→ 43 passed.git grep '@crate.io' -- . ':!.github/') → no matches.🤖 Generated with Claude Code