Dependencies: Update to sqlalchemy-cratedb 0.43.0, remove monkeypatches - #232
Conversation
WalkthroughPython 3.9 support is dropped: the CI matrix switches to 3.10, ChangesPython 3.9 drop, dependency bump, and CrateDB store simplification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 zizmor (1.25.2).github/workflows/main.ymlINFO zizmor: 🌈 zizmor v1.25.2 Caused by: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 84.07% 81.68% -2.39%
==========================================
Files 8 8
Lines 427 415 -12
==========================================
- Hits 359 339 -20
- Misses 68 76 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Line 31: Update the Python version requirement comments in the example files
to match the new minimum version specified in pyproject.toml. Locate the
requires-python comment at line 5 in both examples/minimal/hellodb.py and
examples/contrib/cratedb_cleanup.py, and change the version constraint from
">=3.9" to ">=3.10" in each file to align with the pyproject.toml requirement of
requires-python = ">=3.10".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 76caef7e-2165-4d8c-a932-763332dfe01e
📒 Files selected for processing (4)
.github/workflows/main.ymlCHANGES.mdpyproject.tomlsupertask/store/cratedb.py
| { name = "Andreas Motl", email = "andreas.motl@crate.io" }, | ||
| ] | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.10" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify stale Python runtime hints in examples.
rg -n --iglob 'examples/**/*.py' 'requires-python\s*=\s*">=3\.9"'Repository: pyveci/supertask
Length of output: 184
Update example file Python version comments to match the new requirement floor of >=3.10.
The example files at examples/minimal/hellodb.py line 5 and examples/contrib/cratedb_cleanup.py line 5 still have # requires-python = ">=3.9" while pyproject.toml line 31 specifies requires-python = ">=3.10". Update these comments to align with the new minimum requirement.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pyproject.toml` at line 31, Update the Python version requirement comments in
the example files to match the new minimum version specified in pyproject.toml.
Locate the requires-python comment at line 5 in both examples/minimal/hellodb.py
and examples/contrib/cratedb_cleanup.py, and change the version constraint from
">=3.9" to ">=3.10" in each file to align with the pyproject.toml requirement of
requires-python = ">=3.10".
About
Remove custom monkeypatches after release of the SQLAlchemy dialect.
References