Fix: Issue #1936 CalcCellValue silently fails when formula is =OTHER_FORMULA

[abdelaziz-ouhammou]

Fix: Issue #1936 CalcCellValue silently fails when formula is =OTHER_FORMULA

PR Details

Return Error if it doesn't have "#N/A"

Related Issue

CalcCellValue silently fails when formula is =OTHER_CELL and OTHER_CELL has a formula evaluation error #1936

How Has This Been Tested

I added a unit test for the changes.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (d81b4c8) to head (dd5c57a).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1962   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          32       32           
  Lines       24981    24983    +2     
=======================================
+ Hits        24809    24811    +2     
  Misses         92       92           
  Partials       80       80           

Flag	Coverage Δ
unittests	99.31% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[paolobarbolini]

What is missing for this to be merged?

[xuri]

Thanks for your contribution, sorry for my late reply. This fix can be mitigated for the issue, but can not resolve the root cause of this issue. I think we need to let the parseToken function return value to formulaArg data type, the error context was missing caused by calcAdd, calcG, calcGe series function return value data type conversion.

In addition, I don't suggest add more test workbook files, generate the workbook by unit tests code would be better.