Add qdrant-edit tool for updating stored memories#121
Open
sascha08-15 wants to merge 2 commits intoqdrant:masterfrom
Open
Add qdrant-edit tool for updating stored memories#121sascha08-15 wants to merge 2 commits intoqdrant:masterfrom
sascha08-15 wants to merge 2 commits intoqdrant:masterfrom
Conversation
Author
|
Manual MCP Inspector validation is done for the edit path. Verified through One behavioral note from the same validation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
qdrant-edittool that updates the closest matching memory in place, so stored information can be corrected without creating duplicate or stale entries.QdrantConnector.edit()— finds the closest matching point via semantic search, rewrites that point in place, and preserves existing metadata when replacement metadata is omittedqdrant-edittool — registered alongsideqdrant-store(write-mode only), reuses the same collection binding and filter ergonomics asqdrant-findTOOL_EDIT_DESCRIPTION— customizable tool description via environment variable, consistent with the existing tool description patternread_onlyexposure and defaultCOLLECTION_NAMEbinding at the registered tool levelMotivation
Issue #74 asks for edit/delete support so memories can be corrected instead of duplicated over time. PR #116 covers deletion; this PR covers the edit half by letting callers replace the nearest matching memory while keeping its point identity.
Test plan
read_onlyand defaultCOLLECTION_NAME@modelcontextprotocol/inspector --clipytestrun in a normal networked environmentInspector flow validated:
tools/listexposesqdrant-find,qdrant-store, andqdrant-editqdrant-storestores a memory successfullyqdrant-editupdates a stored memory successfullymetadatapreserves the existing metadata on the updated memoryqdrant-findreturns the updated content and metadata after the editread_onlymode exposes onlyqdrant-findDesign decisions
qdrant-find— the edit tool supports the same query filter flow and respects default collection bindingif not self.qdrant_settings.read_only:block, consistent withqdrant-store