Adapt c-hash-sig for kagome-crates integration#1
Open
kamilsa wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the build script to extract C binding generation logic into a shared build-helper crate, and renames the package from pq-bindings-c-rust to c_hash_sig_crust.
Key changes:
- Simplified
build.rsby delegating cbindgen logic to an externalbuild-helpercrate - Renamed package from
pq-bindings-c-rusttoc_hash_sig_crustinCargo.toml - Replaced direct
cbindgendependency with a path dependency onbuild-helper
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build.rs | Replaced inline cbindgen configuration with a call to build_helper::run_cbindgen() |
| Cargo.toml | Renamed package and replaced cbindgen build dependency with build-helper path dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.