-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[Postgres] Update styles to match new layer name when layer is renamed #66391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JanCaha
wants to merge
8
commits into
qgis:master
Choose a base branch
from
JanCaha:fix-65360
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+145
−0
Open
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c9ab8d8
add renaming of styles, when tables is renamed
JanCaha 8074033
add test case for provider renameVectorTable
JanCaha a20cb46
add guards
JanCaha bec7815
update style table on table move
JanCaha d84f810
add test case for style relinking on table move to another schema
JanCaha bea9444
Update src/providers/postgres/qgspostgresdataitemguiprovider.cpp
JanCaha ee2ae17
catch error in renaming style, and just log it since it is not fatal
JanCaha 3d533b6
change conn obtaining
JanCaha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to check if the style exists (e.g. with QgsProviderMetadata::styleExists ) before calling executeSqlPrivate on a not-existing table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to use QgsPostgresUtils::tableExists with connection acqusition, since the name of style is not known forQgsProviderMetadata::styleExists and i did not want to use QgsPostgresRasterProviderMetadata::listStyles as it seemed like an overkill.