[mssql] Move count of feature subset rows to featureCount #66401
Open
nyalldawson wants to merge 3 commits into
Open
[mssql] Move count of feature subset rows to featureCount #66401nyalldawson wants to merge 3 commits into
nyalldawson wants to merge 3 commits into
Conversation
Match behavior of other providers, where the feature count is NOT retrieved immediately on calling setSubsetString, and swap setSubsetString to a much cheaper SQL to test the validity of the string. Also matches the provider to the same feature count caching behavior as seen in other providers (postgres, ogr) where the value is retrieved once and never updated until manually re-requested Fixes qgis#64894
Copy logic from postgres provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Match behavior of other providers, where the feature count is NOT retrieved immediately on calling setSubsetString, and swap setSubsetString to a much cheaper SQL to test the validity of the string.
Also matches the provider to the same feature count caching behavior as seen in other providers (postgres, ogr) where the value is retrieved once and never updated until manually re-requested
Fixes #64894
AI tool usage