Remove opaque logic preventing some layout grid annotations from showing

[nyalldawson]

This goes WAYYYY back, and there's no clues as to why it's here. It prevents the first grid label from showing in some circumstances, giving users NO way to force this label to show.

I suspect it was added as a quick workaround to fix one user's particular map situation.

If a user wants to explicitly hide a particular annotation, there's better ways to do that now -- eg using expression based annotation visibility.

AI tool usage

• AI tool(s) (Copilot, Claude, or something similar) supported my development of this PR. See our policy about AI tool use. Use of AI tools must be indicated. Failure to be honest might result in banning.

[nyalldawson]

possibly relates to #45876

[github-actions]

Tests failed for Qt 6 (ALL_BUT_PROVIDERS - ubuntu)

One or more tests failed using the build from commit a8be641

layoutexporter_exporthittestlegendupdate_1

layoutexporter_exporthittestlegendupdate_1

Test failed at testHitTestLegendUpdate at tests/src/python/test_qgslayoutexporter.py:1886

Rendered image did not match tests/testdata/control_images/layout_exporter/expected_layoutexporter_exporthittestlegendupdate_1/expected_layoutexporter_exporthittestlegendupdate_1.png (found 233856 pixels different)

composer_legend_reference_point

composer_legend_reference_point

Test failed at testReferencePoint at tests/src/python/test_qgslayoutlegend.py:1252

Rendered image did not match tests/testdata/control_images/composer_legend/expected_composer_legend_reference_point/expected_composer_legend_reference_point.png (found 29010 pixels different)

composer_legend_symbol_expression

composer_legend_symbol_expression

Test failed at testSymbolExpressionRender at tests/src/python/test_qgslayoutlegend.py:911

Rendered image did not match tests/testdata/control_images/composer_legend/expected_composer_legend_symbol_expression/expected_composer_legend_symbol_expression.png (found 409943 pixels different)

legend_multiple_filter_maps

legend_multiple_filter_maps

Test failed at test_filter_by_map_content_rendering at tests/src/python/test_qgslayoutlegend.py:1503

Rendered image did not match tests/testdata/control_images/composer_legend/expected_legend_multiple_filter_maps/expected_legend_multiple_filter_maps.png (found 402 pixels different)

legend_multiple_filter_maps_different_layers

legend_multiple_filter_maps_different_layers

Test failed at test_filter_by_map_content_rendering_different_layers at tests/src/python/test_qgslayoutlegend.py:1609

Rendered image did not match tests/testdata/control_images/composer_legend/expected_legend_multiple_filter_maps_different_layers/expected_legend_multiple_filter_maps_different_layers.png (found 402 pixels different)

legend_multiple_filter_maps_different_layers_atlas

legend_multiple_filter_maps_different_layers_atlas

Test failed at test_filter_by_map_content_rendering_different_layers_in_atlas at tests/src/python/test_qgslayoutlegend.py:1769

Rendered image did not match tests/testdata/control_images/composer_legend/expected_legend_multiple_filter_maps_different_layers_atlas/expected_legend_multiple_filter_maps_different_layers_atlas.png (found 917 pixels different)

composermap_annotation_empty

composermap_annotation_empty

Test failed at testMainAnnotationLayer at tests/src/python/test_qgslayoutmap.py:1096

Rendered image did not match tests/testdata/control_images/composer_map/expected_composermap_annotation_empty/expected_composermap_annotation_empty.png (found 203919 pixels different)

composermap_blend_mode

composermap_blend_mode

Test failed at test_blend_mode_designer_preview at tests/src/python/test_qgslayoutmap.py:300

Rendered image did not match tests/testdata/control_images/composer_map/expected_composermap_blend_mode/expected_composermap_blend_mode.png (found 17437 pixels different)

composermap_opacity

composermap_opacity

Test failed at test_opacity_rendering_designer_preview at tests/src/python/test_qgslayoutmap.py:192

Rendered image did not match tests/testdata/control_images/composer_map/expected_composermap_opacity/expected_composermap_opacity.png (found 19849 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

[github-actions]

Tests failed for Qt 6 (ALL_BUT_PROVIDERS - fedora)

One or more tests failed using the build from commit a8be641

layoutexporter_exporthittestlegendupdate_1

layoutexporter_exporthittestlegendupdate_1

Test failed at testHitTestLegendUpdate at tests/src/python/test_qgslayoutexporter.py:1886

Rendered image did not match tests/testdata/control_images/layout_exporter/expected_layoutexporter_exporthittestlegendupdate_1/expected_layoutexporter_exporthittestlegendupdate_1.png (found 233856 pixels different)

composer_legend_reference_point

composer_legend_reference_point

Test failed at testReferencePoint at tests/src/python/test_qgslayoutlegend.py:1252

Rendered image did not match tests/testdata/control_images/composer_legend/expected_composer_legend_reference_point/expected_composer_legend_reference_point.png (found 29010 pixels different)

composer_legend_symbol_expression

composer_legend_symbol_expression

Test failed at testSymbolExpressionRender at tests/src/python/test_qgslayoutlegend.py:911

Rendered image did not match tests/testdata/control_images/composer_legend/expected_composer_legend_symbol_expression/expected_composer_legend_symbol_expression.png (found 409943 pixels different)

legend_multiple_filter_maps

legend_multiple_filter_maps

Test failed at test_filter_by_map_content_rendering at tests/src/python/test_qgslayoutlegend.py:1503

Rendered image did not match tests/testdata/control_images/composer_legend/expected_legend_multiple_filter_maps/expected_legend_multiple_filter_maps.png (found 402 pixels different)

legend_multiple_filter_maps_different_layers

legend_multiple_filter_maps_different_layers

Test failed at test_filter_by_map_content_rendering_different_layers at tests/src/python/test_qgslayoutlegend.py:1609

Rendered image did not match tests/testdata/control_images/composer_legend/expected_legend_multiple_filter_maps_different_layers/expected_legend_multiple_filter_maps_different_layers.png (found 402 pixels different)

legend_multiple_filter_maps_different_layers_atlas

legend_multiple_filter_maps_different_layers_atlas

Test failed at test_filter_by_map_content_rendering_different_layers_in_atlas at tests/src/python/test_qgslayoutlegend.py:1769

Rendered image did not match tests/testdata/control_images/composer_legend/expected_legend_multiple_filter_maps_different_layers_atlas/expected_legend_multiple_filter_maps_different_layers_atlas.png (found 917 pixels different)

composermap_annotation_empty

composermap_annotation_empty

Test failed at testMainAnnotationLayer at tests/src/python/test_qgslayoutmap.py:1096

Rendered image did not match tests/testdata/control_images/composer_map/expected_composermap_annotation_empty/expected_composermap_annotation_empty.png (found 203919 pixels different)

composermap_blend_mode

composermap_blend_mode

Test failed at test_blend_mode_designer_preview at tests/src/python/test_qgslayoutmap.py:300

Rendered image did not match tests/testdata/control_images/composer_map/expected_composermap_blend_mode/expected_composermap_blend_mode.png (found 17437 pixels different)

composermap_opacity

composermap_opacity

Test failed at test_opacity_rendering_designer_preview at tests/src/python/test_qgslayoutmap.py:192

Rendered image did not match tests/testdata/control_images/composer_map/expected_composermap_opacity/expected_composermap_opacity.png (found 19849 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.