[ClangTidy] Rework clang tidy job (Again)#66435
Open
troopa81 wants to merge 1 commit into
Open
Conversation
- Disable precompiled header and unity build which break the workflow - Fail correctly using WarningsAsErrors (instead of tee + grep) - Cleanup the way we install/launch clang-tidy-diff - Remove the useless clang-tidy.sh (clang-tidy is enougth)
troopa81
force-pushed
the
fix_clangtidy_disabling_pch
branch
from
c2dfd5d to
314bd58
Compare
Contributor
Author
|
unrelated test failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes previous solution now reverted #66355.
Use the same logic as pre-commit to apply clang-tidy-diff on the appropriate set of commits. Lot of modification were missed before.
Also:
To fix the pch error, I just propose to disable precompiled headers. I tested it on several clang-tidy issues and everything seems to work neatly this time.
AI tool usage