add(configuration): ability to store configuration in [tool:qgis-plugin-ci] section in plugin's metadata.txt#416
Open
Guts wants to merge 1 commit into
Open
Conversation
…in-c] section in plugin's metadata.txt
e08709f to
4d20dcb
Compare
3nids
reviewed
Jun 10, 2026
3nids
left a comment
Member
There was a problem hiding this comment.
Tihs makes sense to me.
Some thoughts though:
- adding a 4th config option for me should wait for v3. There we decide for a single source of truth to reduce code quantity and chances of different behaviors? -- maybe 2, but not 4 ;)
- I guess this will mean adding a new param to the CLI to give it the location of the metadata file (this will be one parameter less for the plugin path). Other options are non valid for me (moving/copying or configuring) since that would mean a required building step to test the plugin while you develop.
I'm just seeing the need for a cleanup before putting more, but I'm ok to make it land in v2 if you want to, no strong opinion.
I don't think so. I guess the checks are mainly checking on missing mandatory fields rather than extra ones and wouldn't probably take them into consideration (not saved in the DB, will stay in the metadata) if not declared in the validators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We already reading/writing the plugin's metadata.txt so why not loading full config from there? Well, talking with colleagues, from a plugin dev perspective, it looks like a good idea to store everything in the same config file.
@Xpirix @timlinux is there a risk to see this extra section spotted by checks running at publish time?
plugin_pathis still mandatory but maybe we could add a small lookup logic tyo find it (as parent folder of the metadata.txt) in a next PR?I used claude.ai to write unit tests.
Funded by Oslandia.
Author's checklist
Fixes #11111at the bottom of the commit message.Tip
If you forgot to do this, don't be shy and write the same statement into this text field with the pull request description.
AI tool usage
Reviewer's checklist