Skip to content

Minor fixes for SNZ pulse#1268

Merged
RoyStegeman merged 15 commits into
mainfrom
fix-snz
Jun 29, 2026
Merged

Minor fixes for SNZ pulse#1268
RoyStegeman merged 15 commits into
mainfrom
fix-snz

Conversation

@andrea-pasquale

Copy link
Copy Markdown
Contributor

No description provided.

andrea-pasquale added a commit that referenced this pull request Oct 23, 2025
andrea-pasquale added a commit that referenced this pull request Oct 23, 2025
@codecov

codecov Bot commented Oct 23, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.35683% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.83%. Comparing base (a9eb360) to head (e218b46).

Files with missing lines Patch % Lines
...al/protocols/two_qubit_interaction/snz_optimize.py 97.40% 2 Missing ⚠️
...ocols/two_qubit_interaction/snz_optimize_t_idle.py 97.46% 2 Missing ⚠️
..._qubit_interaction/snz_optimize_t_idle_vs_t_tot.py 97.10% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
- Coverage   91.87%   91.83%   -0.05%     
==========================================
  Files         147      147              
  Lines       11583    11633      +50     
==========================================
+ Hits        10642    10683      +41     
- Misses        941      950       +9     
Flag Coverage Δ
unittests 91.83% <97.35%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/qibocal/protocols/two_qubit_interaction/utils.py 74.07% <100.00%> (-1.79%) ⬇️
...al/protocols/two_qubit_interaction/snz_optimize.py 98.70% <97.40%> (-0.65%) ⬇️
...ocols/two_qubit_interaction/snz_optimize_t_idle.py 98.61% <97.46%> (-1.39%) ⬇️
..._qubit_interaction/snz_optimize_t_idle_vs_t_tot.py 98.50% <97.10%> (-1.50%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrea-pasquale

Copy link
Copy Markdown
Contributor Author

I've verified the code with the emulator and the results seems to agree well with the results shown in the paper http://login.qrccluster.com:9000/NMSeewXsQzi_XkdULbjIaw==/

@alecandido

Copy link
Copy Markdown
Member
image

Wonderful!

How much computing time did it take for the full picture?

@andrea-pasquale

Copy link
Copy Markdown
Contributor Author
image

Wonderful!

How much computing time did it take for the full picture?

Roughly 11 hours which is not great

@andrea-pasquale andrea-pasquale marked this pull request as ready for review November 13, 2025 06:59
andrea-pasquale added a commit that referenced this pull request Nov 26, 2025
RoyStegeman pushed a commit that referenced this pull request Jun 22, 2026
RoyStegeman pushed a commit that referenced this pull request Jun 22, 2026
Base automatically changed from fix-vz to main June 22, 2026 17:07
@RoyStegeman RoyStegeman requested review from a team June 22, 2026 17:07
@RoyStegeman RoyStegeman added this pull request to the merge queue Jun 29, 2026
Merged via the queue into main with commit b733c2a Jun 29, 2026
61 of 63 checks passed
@RoyStegeman RoyStegeman deleted the fix-snz branch June 29, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants