Long t1#1366
Open
jevillegasd wants to merge 3 commits into
Open
Conversation
for more information, see https://pre-commit.ci
jevillegasd
commented
Feb 5, 2026
| ) -> T1Data: | ||
| """Data acquisition for T1 experiment.""" | ||
|
|
||
| num_delays = int(params.delay_before_readout_end // 65004) + 1 |
Contributor
Author
There was a problem hiding this comment.
Is the maximum size stored somewhere in the driver object, maybe we can read from there instead of hard coding it here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
- Coverage 96.96% 96.88% -0.08%
==========================================
Files 133 133
Lines 10335 10338 +3
==========================================
- Hits 10021 10016 -5
- Misses 314 322 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty straight forward and addressed in 1363, and for now probably we only need long T1 so we shouldn't need changes to other routines while qblox's (and other electronics') ssupport long waits.