update minum delay to be compatible with Quantum Machines#1385
update minum delay to be compatible with Quantum Machines#1385jevillegasd wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 96.86% 96.73% -0.13%
==========================================
Files 133 133
Lines 10457 10457
==========================================
- Hits 10129 10116 -13
- Misses 328 341 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
alecandido
left a comment
There was a problem hiding this comment.
Sorry for the very late reply. I was postponing because of the failing tests, but they are actually failing at random... The change is minimal, and certainly fine.
|
Btw, I agree it should be eventually moved to the drivers. It does not make sense to limit all the instruments to the one with the strongest requirement. In any case, we already have a close enough issue, and we can revisit this when we will look deeper into that qiboteam/qibolab#854 |
A tof routine while using OPX1000 returns
This can be changed in the
MINIMUM_TOFconstant (this PR), or perhaps be part of the instrument bounds (part of the driver or in the configs json)