Skip to content

fix: examples for Adaptive Profile#49

Merged
bettinaheim merged 4 commits into
qir-alliance:mainfrom
qartik:fix-adaptive-ir-fns-spec
Jul 30, 2025
Merged

fix: examples for Adaptive Profile#49
bettinaheim merged 4 commits into
qir-alliance:mainfrom
qartik:fix-adaptive-ir-fns-spec

Conversation

@qartik

@qartik qartik commented May 30, 2025

Copy link
Copy Markdown
Contributor

I added section headers for the two primary examples and fixed the syntactic and semantic issues with the example QIR.

  1. need @ before each cnot call and a terminator in swap
  2. type is required before values and calls
  3. In triple, without a label like body:, %1 cannot be used as it is implicitly used for the label for the block and LLVM errors out with error: instruction expected to be numbered '%2'
  4. correct type in call to triple
  5. Fix for the following error:
llvm-as: adaptive_loops.ll:11:85: error: invalid use of function-local name
  call void @__quantum__qis__cnot__body(%Qubit* null, %Qubit* nonnull inttoptr (i64 %0 to %Qubit*))
                                                                                    ^

@qartik qartik force-pushed the fix-adaptive-ir-fns-spec branch from dddbedf to 37bed58 Compare May 30, 2025 21:19
@qartik qartik marked this pull request as ready for review May 30, 2025 21:19
qartik added 2 commits June 11, 2025 11:45
or we get the following error:

llvm-as: adaptive_loops.ll:11:85: error: invalid use of function-local name
  call void @__quantum__qis__cnot__body(%Qubit* null, %Qubit* nonnull inttoptr (i64 %0 to %Qubit*))
                                                                                    ^
@qartik qartik force-pushed the fix-adaptive-ir-fns-spec branch from a7b8cca to f0f8b6e Compare June 12, 2025 21:31
@qartik

qartik commented Jun 26, 2025

Copy link
Copy Markdown
Contributor Author

Hi @swernli, @bettinaheim, could you review this PR?

@swernli swernli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@qartik

qartik commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

@swernli I am not seeing a merge button. It's either restricted for Contributors or less likely the CLA bot check also needs to pass. Could you or someone else help merge?

@swernli

swernli commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service rerun

@swernli

swernli commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Hmm... looks like the CLA bot is missing a Personal Access Token to be able to run. @bettinaheim and @billti do you know if you can configure this or otherwise override? It seems I don't have permissions to that part of the repo configuration.

@qartik qartik force-pushed the fix-adaptive-ir-fns-spec branch from 8897bce to f0f8b6e Compare July 2, 2025 21:02
@qartik

qartik commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Hmm... looks like the CLA bot is missing a Personal Access Token to be able to run. @bettinaheim and @billti do you know if you can configure this or otherwise override? It seems I don't have permissions to that part of the repo configuration.

See my PR at #53 for some context.

@qartik

qartik commented Jul 14, 2025

Copy link
Copy Markdown
Contributor Author

@idavis The CLA Assistant still seems broken. Do you think we should consider setting it from scratch?

@idavis

idavis commented Jul 14, 2025

Copy link
Copy Markdown
Collaborator

@qartik Perhaps. I was trying to get it working last week and was running into issues. I'll take another pass at it shortly.

@qartik

qartik commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

@qartik Perhaps. I was trying to get it working last week and was running into issues. I'll take another pass at it shortly.

Good news is that the CLA bot in another repo in this org is working: qir-alliance/.github#46

@bettinaheim bettinaheim merged commit 136be9f into qir-alliance:main Jul 30, 2025
1 of 3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 30, 2025
@qartik qartik deleted the fix-adaptive-ir-fns-spec branch July 30, 2025 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants