Skip to content

fix(oxlint-config): avoid restricted global false positives#410

Merged
egilsster merged 2 commits into
mainfrom
fix/oxlint-restricted-globals
Jun 25, 2026
Merged

fix(oxlint-config): avoid restricted global false positives#410
egilsster merged 2 commits into
mainfrom
fix/oxlint-restricted-globals

Conversation

@egilsster

@egilsster egilsster commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • stop applying confusing-browser-globals through oxlint no-restricted-globals
  • keep bare isFinite/isNaN restrictions and port the ESLint preset restricted global-property list to oxlint
  • remove the unused confusing-browser-globals dependency/type shim
  • add regression coverage and regenerated oxlint config snapshots

Validation

  • pnpm lint
  • pnpm check-types
  • pnpm test
  • pnpm format:check
  • qcs-ui-common linked to local @qlik/oxlint-config: pnpm exec oxlint src/storybook/MoreMenu.stories.tsx --deny-warnings && pnpm lint

Stop applying the confusing-browser-globals list through oxlint's no-restricted-globals compatibility rule, which flags shadowed callback parameters like event in oxlint 1.71.0.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@egilsster egilsster requested a review from a team as a code owner June 25, 2026 08:07
@changeset-bot

changeset-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 598ae51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@qlik/oxlint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Mirror the ESLint preset's restricted global-property list in the oxlint recommended preset so window/self/global isFinite and isNaN plus legacy accessors stay covered without reintroducing confusing-browser-globals.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@egilsster egilsster merged commit 6e2080b into main Jun 25, 2026
7 checks passed
@egilsster egilsster deleted the fix/oxlint-restricted-globals branch June 25, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants