iq-9075-evk: build sdcc feature DTs as overlays#1952
iq-9075-evk: build sdcc feature DTs as overlays#1952mchunara007 wants to merge 2 commits intoqualcomm-linux:masterfrom
Conversation
mchunara007
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Commit message should start by the description of the problem the commit tries to solve.
mchunara007
force-pushed
the
lemans_fitdtb_sdcc
branch
from
88b810e to
f8ee98d
Compare
| qcom,qcs9075-iot-subtype1 \ | ||
| qcom,qcs9075v2-iot-subtype1 \ | ||
| " | ||
| FIT_DTB_COMPATIBLE[lemans-evk+lemans-evk-sd-card] = " \ |
There was a problem hiding this comment.
So, what happens with the default setting?
There was a problem hiding this comment.
By default, the UEFI would populate 'sdcard' metadata. only in case of eMMC attached, 'emmc' will get populated. So by default this would select the lemans-evk-sd-card overlay
There was a problem hiding this comment.
Then why do we need the -sd-card at all?? Why can't it be a default here too, being overriden only if emmc is attached.
| qcom,qcs9075-iot-subtype1-sdcard \ | ||
| qcom,qcs9075v2-iot-subtype1-sdcard \ | ||
| " | ||
| FIT_DTB_COMPATIBLE[lemans-evk+lemans-evk-ifp-mezzanine+lemans-evk-emmc] = " \ |
There was a problem hiding this comment.
Can there be a non-ifp board with eMMC?
There was a problem hiding this comment.
For LeMans EVK, the eMMC is present on ifp mezz board, so non-ifp board with eMMC is not possible.
There was a problem hiding this comment.
Is it explained in the commit message? No.
LeMans EVK board supports either eMMC or SD-card, but only one can be active at a time due to shared host controller. The storage medium is selected via a dip switch. Add the sd card and eMMC device tree overlay for the LeMans EVK to KERNEL_DEVICETREE in the iq-9075-evk machine configuration to ensure device tree coverage for LeMans sdcc storage usecase. Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
mchunara007
force-pushed
the
lemans_fitdtb_sdcc
branch
from
f8ee98d to
281a5b2
Compare
Updated the commit message with problem statement. |
Enable metadata based selection for eMMC and SD card as overlays to support both the medium based on the DIP switch selection on the EVK board. Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
mchunara007
force-pushed
the
lemans_fitdtb_sdcc
branch
from
281a5b2 to
a70cdf7
Compare
3 participants
LeMans EVK board supports either eMMC or SD-card, but only one can be
active at a time due to shared host controller. The storage medium is
selected via a dip switch.
Enable metadata based selection for eMMC and SD card as overlays to support both the medium based on the DIP switch selection on the EVK board.