gst-plugins-imsdk-base: Fix installation of gstreamer-qcom-oss-camera-meta-1.0.pc #1992
+45
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| From c7e75527b32d740874f65ba07e48889c6ec9fc3d Mon Sep 17 00:00:00 2001 | ||
| From: Tushar Patra Jamula <tjamula@qti.qualcomm.com> | ||
| Date: Fri, 17 Apr 2026 14:59:07 +0530 | ||
| Subject: [PATCH] cmake: Make camera base pkg-config installation conditional | ||
|
|
||
| Only install the pkg-config file when the camera base library is | ||
| actually built. This prevents orphaned .pc files when the library | ||
| is excluded from the build via EXCLUDE_FROM_ALL. | ||
|
|
||
| Change-Id: I09a495d3db3f47e0b88c08343556f91a9f83b57c | ||
| Signed-off-by: Tushar Patra Jamula <tjamula@qti.qualcomm.com> | ||
|
|
||
| Upstream-Status: Pending | ||
|
Contributor
There was a problem hiding this comment. Why pending? Please send this upstream at least. |
||
| --- | ||
| gst-plugin-base/gst/camera/CMakeLists.txt | 13 +++++++++---- | ||
| 1 file changed, 9 insertions(+), 4 deletions(-) | ||
|
|
||
| diff --git a/gst-plugin-base/gst/camera/CMakeLists.txt b/gst-plugin-base/gst/camera/CMakeLists.txt | ||
| index 12f9f131..d90d8971 100644 | ||
| --- a/gst-plugin-base/gst/camera/CMakeLists.txt | ||
| +++ b/gst-plugin-base/gst/camera/CMakeLists.txt | ||
| @@ -62,7 +62,12 @@ configure_file( | ||
| @ONLY | ||
| ) | ||
|
|
||
| -install( | ||
| - FILES ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}.pc | ||
| - DESTINATION ${GST_PLUGINS_QTI_OSS_INSTALL_LIBDIR}/pkgconfig | ||
| -) | ||
| +install(CODE " | ||
| + if(EXISTS \"$<TARGET_FILE:${TARGET_NAME}>\") | ||
| + file(INSTALL | ||
| + DESTINATION \"${GST_PLUGINS_QTI_OSS_INSTALL_LIBDIR}/pkgconfig\" | ||
| + TYPE FILE | ||
| + FILES \"${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}.pc\" | ||
| + ) | ||
| + endif() | ||
| +") | ||
| -- | ||
| 2.43.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Gerrit tags, missing Upstream-Status (wich definitely should be Backport)