Enable JPEG Encoder (jpegenc) Plugin Support for prop image#2010
Open
JaiShiv05 wants to merge 2 commits intoqualcomm-linux:masterfrom
Open
Enable JPEG Encoder (jpegenc) Plugin Support for prop image#2010JaiShiv05 wants to merge 2 commits intoqualcomm-linux:masterfrom
JaiShiv05 wants to merge 2 commits intoqualcomm-linux:masterfrom
Conversation
JaiShiv05
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
JaiShiv05
force-pushed
the
enable_jpeg_enc
branch
from
05aaac8 to
2727e96
Compare
| @@ -1 +1 @@ | |||
| PACKAGECONFIG:append = " camera-base qmmfsrc" | |||
| PACKAGECONFIG:append = " camera-base qmmfsrc jpegenc" | |||
Contributor
There was a problem hiding this comment.
Can you please add something on the commit explaining why this is done in dynamic-layers? To me it seems that it's because it depends on camera-service, could that be the reason?
lumag
requested changes
Apr 21, 2026
Contributor
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Why is this separate from qmmfsrc plugin? Can we have a single config for all CamX plugins?
JaiShiv05
force-pushed
the
enable_jpeg_enc
branch
from
2727e96 to
3f45ad1
Compare
Contributor
Author
Done. |
Renamed and unified camera-related PACKAGECONFIG from camera-base/qmmfsrc into a single camera option. Enabled the following features when camera is selected: - Camera base - Qmmfsrc plugin - VHDR and EIS modes - Offline IFE support - JPEG encoder plugin Ensured all related features are cleanly disabled when the camera config is turned off. Signed-off-by: Jai Shiv <jshiv@qti.qualcomm.com>
Update gst-plugins-imsdk-prop bbappend to use the unified 'camera' PACKAGECONFIG instead of seperate 'camera-base' and 'qmmfsrc' options. This change is applied in the dynamic layer because the 'camera' PACKAGECONFIG depends on camera-service, which is platform-specific and provided by the dynamic layers. Keeping this enablement in dynamic-layers avoids introducing camera-service dependencies into the generic recipe and ensures correct feature enablement only when the camera stack is available. Signed-off-by: Jai Shiv <jshiv@qti.qualcomm.com>
JaiShiv05
force-pushed
the
enable_jpeg_enc
branch
from
3f45ad1 to
ff68dab
Compare
lumag
requested changes
Apr 23, 2026
| @@ -1 +1 @@ | |||
| PACKAGECONFIG:append = " camera-base qmmfsrc" | |||
| PACKAGECONFIG:append = " camera" | |||
Contributor
There was a problem hiding this comment.
Camera support is broken between these two commits. PLease squash them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the GStreamer jpegenc plugin by enabling it through the unified camera PACKAGECONFIG in the imsdk common configuration. This introduces offline JPEG encoding alongside existing imsdk camera plugins, while keeping the camera-service dependency scoped to platform-specific dynamic layers.