feat(cli/server): hint --host 0.0.0.0 when bound to loopback - #1264
Draft
RemiliaForever (RemiliaForever) wants to merge 1 commit into
Draft
feat(cli/server): hint --host 0.0.0.0 when bound to loopback#1264RemiliaForever (RemiliaForever) wants to merge 1 commit into
RemiliaForever (RemiliaForever) wants to merge 1 commit into
Conversation
serve prints a hint line when bound to a loopback address (127.0.0.0/8, localhost, ::1), pointing users at --host 0.0.0.0:<port> to expose the server on the LAN. Non-loopback binds print nothing extra; malformed hosts are treated as non-loopback. Replaces the placeholder package_test.go with server_test.go covering hostBindingHint. Refs qualcomm/GenieX#1295 (item 5). Signed-off-by: RemiliaForever <remilia@koumakan.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
One of the four UX items from the customer feedback report in #1295, split out from #1255. Output-side only; no SDK changes.
serveprints a hint line when bound to a loopback address (127.0.0.0/8,localhost,::1), pointing users at--host 0.0.0.0:<port>to expose the server on the LAN.package_test.gowithserver_test.gocoveringhostBindingHint.Related Issue
Refs qualcomm/GenieX#1295 (item 5). Split out from #1255.
Type of Change
Checklist
Additional Context
Verified manually on Windows ARM64 (Snapdragon X Elite): default bind printed the hint;
--host 0.0.0.0:18181printed no hint;[::1]:18181printed the hint.