This repository was archived by the owner on Jan 1, 2023. It is now read-only.
Replace websockets library with websocket-client for support proxy.#31
Open
nomadalex wants to merge 2 commits intoquan-digital:masterfrom
Open
Replace websockets library with websocket-client for support proxy.#31nomadalex wants to merge 2 commits intoquan-digital:masterfrom
nomadalex wants to merge 2 commits intoquan-digital:masterfrom
Conversation
Because websockets do not support proxy.
nomadalex
changed the title
nomadalex
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because websockets library do not support proxy but websocket-client works perfect.
And I honestly find the fact that the issue for proxy support of websockets (python-websockets/websockets#364) has been open for 3 years and has a "funding needed" label. That's amazing me.