-
Notifications
You must be signed in to change notification settings - Fork 32
Pixi dependency management #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 55 commits
a8e8a11
cd36ad1
1ec8567
b8bea84
1e2a5a4
662be96
5cb6568
d4438e6
dbca697
0927397
201f406
9db683b
fc6e258
3627fc6
1d3fe09
c2231c6
719d289
5d544bb
bca3359
c35ca17
c15ae22
0bd1440
ad05dfe
b3f256e
3ac1102
3a2c7c1
5ffa9df
baeb0b4
3223050
68f5641
97e80b4
df13f3e
8cf1b5d
3b4b8d2
2ca19cd
abf5121
d2d5b68
e436d4f
36c95fe
62d8bef
1165f38
4b88697
ab985db
7f02edb
6151615
066fee3
3fc045a
80137ed
9ba2b2e
795e7ee
6444223
e935aaa
c9f4cc4
d4ceb11
c336845
ded2a78
4084474
1176983
5db23c0
1c2c1e3
20417ac
e247344
68b8cb4
e8567e0
435284d
e7c7b1d
8f8c60c
75f0b93
471953d
f6f4f54
64ab5b3
7a9c8aa
5d69110
8361db5
2ec689f
b4a7999
62dad6b
d26605a
a8bff89
09f0b93
ea0414d
a08c37b
b122e6c
1882a0a
d4e5d80
f59a3d0
c73b2d7
079b6a1
e0f52ae
bde8e06
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,15 @@ jobs: | |
| run: | ||
| shell: bash -l {0} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v5 | ||
| - uses: prefix-dev/setup-pixi@v0.9.4 | ||
| with: | ||
| pixi-version: v0.67.0 | ||
| cache: true | ||
| cache-write: ${{ github.event_name == 'push' && github.ref_name == 'main' }} | ||
| environments: queens-dev | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the difference between queens-dev and queens-all? I'm just wondering which parts of queens-all we are using neither for the documentation nor for the tests.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very good question. To verify: the environments are defined here
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok got it, thanks for clarifying 👍 In this case, I would like to bring up the point that it might be helpful to rename |
||
| frozen: true | ||
| activate-environment: queens-dev | ||
| - name: Mark repo as safe for git | ||
| run: | | ||
| git config --global --add safe.directory "$GITHUB_WORKSPACE" | ||
|
|
@@ -34,27 +42,18 @@ jobs: | |
| - name: Create links to 4C | ||
| run: | | ||
| ln -s /home/user/4C/bin/ config/4C_build | ||
| - name: Create Python environment | ||
| id: environment | ||
| uses: ./.github/actions/create_python_environment | ||
| - name: Add tutorial dependencies | ||
| env: | ||
| PYTHON_PACKAGE_MANAGER: ${{steps.environment.outputs.ppm}} | ||
| - name: Register Jupyter kernel | ||
| run: | | ||
| $PYTHON_PACKAGE_MANAGER activate queens | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Super nice that we don't have to manually activate the environment in every single shell anymore :) |
||
| pip install -e .[tutorial] | ||
| python -m ipykernel install --user --name queens --display-name "Python (queens)" | ||
| - name: Install xvfb | ||
| run: | | ||
| apt-get update | ||
| apt-get install -y xvfb | ||
| - name: Sphinx build | ||
| env: | ||
| PYTHON_PACKAGE_MANAGER: ${{steps.environment.outputs.ppm}} | ||
| PYTHONPATH: ${{ github.workspace }} | ||
| run: | | ||
| set -euxo pipefail | ||
| $PYTHON_PACKAGE_MANAGER activate queens | ||
| sphinx-apidoc -o doc/source src/ -fMT | ||
| cd doc | ||
| xvfb-run -a sphinx-build -b html -d build/doctrees source build/html -W | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,3 +82,6 @@ venv.bak/ | |
|
|
||
| # best editor ever files | ||
| *.swp | ||
| # pixi environments | ||
| .pixi/* | ||
| !.pixi/config.toml | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I haven't missed anything, we can delete this action now, right?