Feature/kyocera softkey support by RealNameBrand · Pull Request #819 · quik-sms/quik

RealNameBrand · 2026-06-12T04:23:50Z

Hey I've been using quik for over a year now on my KY-42C Kyocera flip phone and it has been working really great.
This is also my first pull request on a public repo. I also just finished college so no real world experience.

I've wanted a more native feel so I did some digging with adb and jadex to try and figure out how built in apps use the soft keys at the bottom of the screen. while researching I came across this blog post of someone that has already figured it out! and the code for it. @wiggleforlife you may be interested in this as another KY-42C user

I don't know too much on java or kotlin or programming for android. But I've managed to make a working demo of quik working with soft keys

Here's some photos on how it looks

MainActivity

ComposeActivity

When long press a message

Sending a text
https://github.com/user-attachments/assets/8a83911b-c892-4c88-8e2a-5763c3f1c503

Again this is just an idea at this point and I'd like feedback on how this could be properly implemented.

Note

Right now if you try to run it on anything other than a kyocera it will crash because its looking for "jp.kyocera.kcfp.util.KCfpSoftkeyGuide" in the KyoceraSoftkeyGuide class in presentation/com/moez/QKSMS/Common/util
I did use AI to help me understand the code and how things worked. At times it was useful and others not.

Inhishonor · 2026-06-12T16:43:12Z

Thank you for this! I am going to hand this off to @wiggleforlife as they have the right hardware to test this. But you will need to rebase on to the latest changes first.

Inhishonor

Thanks for this! I didn't test the changes, this is just code style and maintainability review.

Inhishonor · 2026-06-12T16:44:26Z

+/**
+ *  Code From:
+ * https://habr.com/ru/companies/timeweb/articles/844936/
+ * https://github.com/vladkorotnev/TraditionalT9/blob/c6fe6efab402afc6c2a74bcc17dbfa75cf469428/src/org/nyanya/android/traditionalt9/quirks/kyocera/KYY31SoftkeyGuide.java
+ *
+ * Renamed from KYY31SoftkeyGuide to KyoceraSoftkeyGuide
+ */


Please verify that the license is correct, and we can in fact use it here. If we can use it, we need to provide the license in this file.

The blog (near the end) I found it from mentions he just used Gemini to make it so I don't think there's a license.

Inhishonor · 2026-06-12T16:45:22Z

+        } catch (Exception e) {
+            throw new RuntimeException(e);
+        }


I would prefer this show a user facing error, instead of crashing if it can find the right class.

Inhishonor · 2026-06-12T16:45:38Z

+            throw new RuntimeException(e);
+        }
+    }
+}


Inhishonor · 2026-06-12T16:46:57Z

Please don't comment out code, it clutters out the codebase. We should make a decision on if to include it or not, and leave it at that.

Inhishonor · 2026-06-12T16:47:16Z

+                        val options = arrayOf(
+                            "Attach a contact",
+                            "Schedule message",
+                            "Attach any file",
+                            "Record an audio message",
+                            "Take a photo"


Do these need to be translatable strings?

updated to translatable strings

Inhishonor · 2026-06-12T16:51:48Z

+                softkeyMode = if (selectedIds.isEmpty())
+                    SoftkeyMode.CONVERSATIONS
+                else
+                    SoftkeyMode.CONVERSATIONS_SELECTED


Please use braces here.

Inhishonor · 2026-06-12T16:52:13Z

+                }
+                KeyEvent.KEYCODE_F3 -> {
+                    // Show info
+                    makeToast("Copied", Toast.LENGTH_SHORT)


String please.

Inhishonor · 2026-06-12T16:52:34Z

+        val s = currentState ?: return false
+        val lm = binding.messageList.layoutManager as LinearLayoutManager


These need to be more descriptive variable names.

Inhishonor · 2026-06-12T16:53:18Z

+    }
+
+
+    private fun updateSoftkeys() {


This code is duplicated, we should probably create a Kyocera helper, and store all of these functions there.

Inhishonor · 2026-06-12T16:53:59Z

I would prefer not to include java files, this should be rewritten to Kotlin.

RealNameBrand · 2026-06-13T05:55:41Z

thank you I'll be able to make changes later tomorrow! I'm also newish/inexperienced to using git so bear with me

- Created an interface to allow other devices to implement their softkeys - Fixed crashing if non-kyocera device

- Created an interface to allow other devices to implement their own softkeys - Fixed crashing if non-kyocera device - made strings into translatable strings - changed scrolling onKeyDown actions to have focus after a scroll

RealNameBrand · 2026-06-24T02:52:44Z

I've done some more messing around and one of the things I think would be good is an interface for other devices to implement their own softkeys so I added an interface under util/softKey. right now the interface is a mirror of the kyocera's functions but I may just buy a Sharp flip phone to see if I can add more devices.

I've also added some translatable strings that fit the kyocera softkey convention.

also the onKeyDown and render for each activity feels like it could get messy especially if I added keys for each drawer in the Main Activity. If you have any input on how it could be cleaner I'd appreciate it. I've learned a lot more of the inner working but still feel pretty clueless.

Also changing this to a draft did not see that button when I made the PR

Last thing I have a friend who has the ky-42c also so I'll use them as a tester too :)

Inhishonor requested review from Inhishonor, octoshrimpy and wiggleforlife and removed request for octoshrimpy June 12, 2026 16:43

Inhishonor requested changes Jun 12, 2026

View reviewed changes

RealNameBrand added 2 commits June 13, 2026 20:41

Added kyocera softkey class

014d733

added code to show softkeys in the mainActivity and composeActivity

d91f160

RealNameBrand force-pushed the feature/kyocera-softkey-support branch from f0b8397 to d91f160 Compare June 14, 2026 03:05

RealNameBrand added 4 commits June 15, 2026 18:28

- Converted KyoceraSoftkeyGuide to Kotlin

e6f9006

- Created an interface to allow other devices to implement their softkeys - Fixed crashing if non-kyocera device

- Converted KyoceraSoftkeyGuide to Kotlin

2fe43e3

- Created an interface to allow other devices to implement their own softkeys - Fixed crashing if non-kyocera device - made strings into translatable strings - changed scrolling onKeyDown actions to have focus after a scroll

remove unused kyoceraSoftKey java file

0c64e9b

- Converted KyoceraSoftkeyGuide to Kotlin

02688cf

- Created an interface to allow other devices to implement their own softkeys - Fixed crashing if non-kyocera device - made strings into translatable strings - changed scrolling onKeyDown actions to have focus after a scroll

RealNameBrand marked this pull request as draft June 24, 2026 02:52

		val s = currentState ?: return false
		val lm = binding.messageList.layoutManager as LinearLayoutManager

Uh oh!

Conversation

RealNameBrand commented Jun 12, 2026

Note

Uh oh!

Inhishonor commented Jun 12, 2026

Uh oh!

Inhishonor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Inhishonor Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RealNameBrand commented Jun 13, 2026

Uh oh!

RealNameBrand commented Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Inhishonor Jun 12, 2026 •

edited

Loading