fix(public): download pdf from results page - #52
Merged
Conversation
✅ Deploy Preview for primer-paso-org-portal canceled.
|
✅ Deploy Preview for primer-paso-research canceled.
|
✅ Deploy Preview for primer-paso ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jokroese
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
"Download handover PDF" button on the result page currently throwing 404.
Reason
SvelteKit intercepts same-origin link clicks and tries to handle them through its client-side router. The router only knows how to render +page routes — a raw PDF response from a +server.ts endpoint has no page component, so the navigation throws a 404.
Proposed Solution
Adds data-sveltekit-reload and download attributes to the two handover-PDF links on the result page