Skip to content

Notebook devcontainer#2

Open
jboilard1994 wants to merge 53 commits intorafaelgreca:masterfrom
jboilard1994:notebook-devcontainer
Open

Notebook devcontainer#2
jboilard1994 wants to merge 53 commits intorafaelgreca:masterfrom
jboilard1994:notebook-devcontainer

Conversation

@jboilard1994
Copy link
Copy Markdown

@jboilard1994 jboilard1994 commented Dec 8, 2024

Note that I wanted to make this pul request to my own repo, but it seems I made a mistake,
(I guess you can just look at this and study my changes)

Dev-container :
Implemented Devcontainer contains the following functionalities:

  • Pylance auto-complete
  • Black + flake8 + isort (import sort) + markdown lint for style guide enforcement
  • mypy for type-check linting
  • docker autocomplete
  • gitlens
  • built-in jupyter within vscode extension
  • markdown tools (such as automatic TOC with links from section titles)

pre-commit hooks:

  • Removed in favor of on-save features of above devcontainer features.

Docker :

  • Removed dev-compose containers started explicitly for using jupyter notebook. No longer needed now that vscode extensions handles jupyter notebooks.
  • Now using docker image with python preinstalled.
  • Ordered docker image to limit image layer rebuild size
  • Now initialize a venv, which help with initializing the python environment, and avoid various warnings
  • Also generalized dev / test / prod into one, since splitting their python requirements bring very limited advantages. As such, we only build one image, which will be wrapped differently and execute a different shell command whether it is executed in a dev/test/prod.
    • Removed dev dockerfile and requirements.

For

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Dec 8, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14709036 Triggered RSA Private Key a085eb1 notebooks/docs/SETUP_AWS.md View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to LF file system. can be ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant