Skip to content

Update Base orderbook address to V6#74

Open
findolor wants to merge 9 commits intomainfrom
add-v6-orderbook-contracts
Open

Update Base orderbook address to V6#74
findolor wants to merge 9 commits intomainfrom
add-v6-orderbook-contracts

Conversation

@findolor
Copy link
Copy Markdown
Contributor

@findolor findolor commented Jan 9, 2026

Motivation

Update orderbook contract addresses to V6 across all networks.

Closes #73

Solution

Updated Base network orderbook address from 0x52CEB8eBEf648744fFDDE89F7Bc9C3aC35944775 to 0xFe2411CDa193D9E4e83A5c234C7Fd320101883aC in:

  • settings.yaml
  • src/folio.rain
  • src/fixed-limit.rain
  • src/claims.rain
  • src/fixed-spread.rain
  • src/auction-dca.rain
  • src/dynamic-spread.rain

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • Chores
    • Updated the base orderbook configuration used across multiple strategies and modules (no functional or interface changes).
    • Updated registry mappings to point to new versioned strategy locations for all listed strategies.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 9, 2026

Walkthrough

Updated subgraph tag and replaced the base orderbook contract address and deployment-block across settings, strategy source files, and registry mappings. No changes to exported/public entities or other logic.

Changes

Cohort / File(s) Summary
Configuration
settings.yaml
Updated subgraphs.base tag 2025-10-11-a62b2026-01-22-c13a; updated orderbooks.base.address 0x52CEB8eBEf648744fFDDE89F7Bc9C3aC359447750x498Ff70C5f67e63e53b74551DE31387cf2813986; orderbooks.base.deployment-block 3666725341134692.
Strategy files
src/auction-dca.rain, src/claims.rain, src/dynamic-spread.rain, src/fixed-limit.rain, src/fixed-spread.rain, src/folio.rain
Replaced orderbooks.base.address 0x52CEB8eBEf648744fFDDE89F7Bc9C3aC359447750x498Ff70C5f67e63e53b74551DE31387cf2813986 and orderbooks.base.deployment-block 3666725341134692 in each file; no other logic changes.
Registry mappings
registry (root file)
Updated strategy mapping commit/hash references for keys (fixed-limit, auction-dca, grid, dynamic-spread, canary, claims, fixed-spread, folio) from 8fdd42b50bca8b9c8e9b93a2bb33115c37644a94a6db551aa8d560f0147b352cce6f727b9071204c.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

webapp

Suggested reviewers

  • hardyjosh
  • 0xgleb
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update Base orderbook address to V6' clearly and concisely summarizes the main change in the pull request - updating the Base network orderbook address to V6.
Linked Issues check ✅ Passed The pull request successfully addresses issue #73 by updating the Base network orderbook address across all required files: settings.yaml, src/auction-dca.rain, src/claims.rain, src/dynamic-spread.rain, src/fixed-limit.rain, src/fixed-spread.rain, and src/folio.rain.
Out of Scope Changes check ✅ Passed All changes are within scope: Base orderbook address updates across specified files, registry hash updates for consistency, and subgraph configuration updates - all directly related to V6 orderbook deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @registry:
- Around line 1-8: The registry entries point to commit
d002b72885ed82e862c78032704b907d39ed502b but that commit only updates 7 of the 8
referenced strategy files so grid.rain and canary.rain will remain out-of-sync;
update the registry so all eight strategy URLs reference a commit that actually
includes the updated Base orderbook address (or remove grid.rain and canary.rain
from this commit's entries), ensuring consistency across fixed-limit,
auction-dca, grid.rain, dynamic-spread, canary.rain, claims, fixed-spread, and
folio by using a commit that contains updates for each file or by pointing only
to the files truly changed in d002b72885ed82e862c78032704b907d39ed502b.
📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d61ba6 and 7b2a499.

📒 Files selected for processing (8)
  • registry
  • settings.yaml
  • src/auction-dca.rain
  • src/claims.rain
  • src/dynamic-spread.rain
  • src/fixed-limit.rain
  • src/fixed-spread.rain
  • src/folio.rain
🧰 Additional context used
🧠 Learnings (7)
📓 Common learnings
Learnt from: findolor
Repo: rainlanguage/rain.strategies PR: 59
File: src/fixed-limit.rain:68-68
Timestamp: 2025-09-01T12:19:42.343Z
Learning: In the rain.strategies repository, the team plans to replace contract addresses in the configuration files, and deployment-block values will be updated as part of that broader effort, so placeholder values like 1 are intentionally temporary.
📚 Learning: 2025-09-01T12:19:42.343Z
Learnt from: findolor
Repo: rainlanguage/rain.strategies PR: 59
File: src/fixed-limit.rain:68-68
Timestamp: 2025-09-01T12:19:42.343Z
Learning: In the rain.strategies repository, the team plans to replace contract addresses in the configuration files, and deployment-block values will be updated as part of that broader effort, so placeholder values like 1 are intentionally temporary.

Applied to files:

  • src/auction-dca.rain
  • src/claims.rain
  • settings.yaml
  • src/folio.rain
  • src/fixed-spread.rain
  • src/dynamic-spread.rain
  • registry
  • src/fixed-limit.rain
📚 Learning: 2025-06-19T03:59:46.063Z
Learnt from: Siddharth2207
Repo: rainlanguage/rain.strategies PR: 42
File: src/fixed-limit.rain:19-23
Timestamp: 2025-06-19T03:59:46.063Z
Learning: In rain.strategies configuration files, `arbitrum2` is an intentional alias for the Arbitrum network (same chain-id 42161) but with updated contract addresses. It serves as a deployment target for newer contract versions while maintaining the existing `arbitrum` configuration during transition periods.

Applied to files:

  • src/dynamic-spread.rain
  • registry
  • src/fixed-limit.rain
📚 Learning: 2025-07-26T15:31:37.916Z
Learnt from: 0xgleb
Repo: rainlanguage/rain.strategies PR: 45
File: registry:0-0
Timestamp: 2025-07-26T15:31:37.916Z
Learning: In the rain.strategies repository, the registry file uses full commit SHAs to pin strategy URLs as the current established pattern, rather than using tags or branches, as confirmed by project maintainer 0xgleb.

Applied to files:

  • registry
📚 Learning: 2025-07-03T09:47:48.019Z
Learnt from: thedavidmeister
Repo: rainlanguage/rain.strategies PR: 28
File: src/folio.rain:28-42
Timestamp: 2025-07-03T09:47:48.019Z
Learning: In Rain language strategy files, thedavidmeister prefers intentionally oversimplified setups over complex validation logic, especially in initial implementations like the folio strategy configuration.

Applied to files:

  • registry
📚 Learning: 2025-09-04T12:59:34.219Z
Learnt from: thedavidmeister
Repo: rainlanguage/rain.strategies PR: 60
File: src/dynamic-spread.rain:924-929
Timestamp: 2025-09-04T12:59:34.219Z
Learning: In the Rain Strategies dynamic spread system, the io values cannot be zero due to business logic constraints where baseline uses any(cost-basis-io last-io) and cost-basis-multiplier is positive, making division-by-zero in inv(stored-last-io) mathematically impossible under normal operation.

Applied to files:

  • registry
📚 Learning: 2025-07-03T09:47:14.894Z
Learnt from: thedavidmeister
Repo: rainlanguage/rain.strategies PR: 28
File: src/folio.rain:115-122
Timestamp: 2025-07-03T09:47:14.894Z
Learning: In Rain language folio strategy, the zero balance check using `every(input-vault-before() output-vault-before())` is specifically implemented to prevent trades from executing while users are depositing or withdrawing from vaults, serving as a safety mechanism against race conditions during vault operations.

Applied to files:

  • registry
🔇 Additional comments (8)
settings.yaml (2)

46-46: Subgraph URL update looks correct.

The subgraph URL has been updated to reflect the new V6 deployment timestamp.


67-72: Verify whether the address 0x77Ca4947dce161e122Eb690D475448f092a7d7EB is the correct V6 orderbook contract for Base.

The Base orderbook address is used consistently across all strategy files (folio.rain, fixed-limit.rain, fixed-spread.rain, dynamic-spread.rain, claims.rain, auction-dca.rain), suggesting this was an intentional systematic deployment. However, if the PR description specifies a different address (0xFe2411CDa193D9E4e83A5c234C7Fd320101883aC), confirm whether the code matches the intended deployment or if the address needs to be updated across all files. The other address mentioned appears only in comments.

The deployment-block value is a temporary configuration detail and can be addressed as part of the broader contract address updates during deployment.

src/dynamic-spread.rain (1)

145-148: Base orderbook address updated consistently with other files.

The address change is consistent with the update in settings.yaml. As noted earlier, please verify this is the correct V6 address and whether the deployment-block needs updating for the new contract.

src/fixed-limit.rain (1)

73-76: Base orderbook address updated consistently.

The change aligns with the updates in settings.yaml and other strategy files.

src/fixed-spread.rain (1)

20-24: Base orderbook address updated consistently.

The change is consistent with all other files in this PR.

src/folio.rain (1)

22-22: Address update is consistent with other files.

The Base orderbook address matches the update in src/claims.rain. The same verification concern applies regarding the discrepancy with the PR description's stated address.

src/auction-dca.rain (1)

68-68: Address update is consistent across all strategy files.

The Base orderbook address matches the updates in src/claims.rain and src/folio.rain. Assuming the address discrepancy with the PR description is resolved, this change is correct.

src/claims.rain (1)

22-22: No action needed. The Base orderbook address 0x77Ca4947dce161e122Eb690D475448f092a7d7EB at line 22 is consistent across all strategy files and matches the configuration in settings.yaml. The address 0xFe2411CDa193D9E4e83A5c234C7Fd320101883aC appears only in comments for raindex-subparser configuration and is not the orderbook address.

Likely an incorrect or invalid review comment.

Comment thread registry Outdated
- Address: 0x498Ff70C5f67e63e53b74551DE31387cf2813986
- Deployment block: 41134692
- Subgraph: ob4-base/2026-01-22-c13a
@findolor findolor self-assigned this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update orderbook contract addresses to V6

1 participant