Conversation
WalkthroughUpdated subgraph tag and replaced the base orderbook contract address and deployment-block across settings, strategy source files, and registry mappings. No changes to exported/public entities or other logic. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @registry:
- Around line 1-8: The registry entries point to commit
d002b72885ed82e862c78032704b907d39ed502b but that commit only updates 7 of the 8
referenced strategy files so grid.rain and canary.rain will remain out-of-sync;
update the registry so all eight strategy URLs reference a commit that actually
includes the updated Base orderbook address (or remove grid.rain and canary.rain
from this commit's entries), ensuring consistency across fixed-limit,
auction-dca, grid.rain, dynamic-spread, canary.rain, claims, fixed-spread, and
folio by using a commit that contains updates for each file or by pointing only
to the files truly changed in d002b72885ed82e862c78032704b907d39ed502b.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (8)
registrysettings.yamlsrc/auction-dca.rainsrc/claims.rainsrc/dynamic-spread.rainsrc/fixed-limit.rainsrc/fixed-spread.rainsrc/folio.rain
🧰 Additional context used
🧠 Learnings (7)
📓 Common learnings
Learnt from: findolor
Repo: rainlanguage/rain.strategies PR: 59
File: src/fixed-limit.rain:68-68
Timestamp: 2025-09-01T12:19:42.343Z
Learning: In the rain.strategies repository, the team plans to replace contract addresses in the configuration files, and deployment-block values will be updated as part of that broader effort, so placeholder values like 1 are intentionally temporary.
📚 Learning: 2025-09-01T12:19:42.343Z
Learnt from: findolor
Repo: rainlanguage/rain.strategies PR: 59
File: src/fixed-limit.rain:68-68
Timestamp: 2025-09-01T12:19:42.343Z
Learning: In the rain.strategies repository, the team plans to replace contract addresses in the configuration files, and deployment-block values will be updated as part of that broader effort, so placeholder values like 1 are intentionally temporary.
Applied to files:
src/auction-dca.rainsrc/claims.rainsettings.yamlsrc/folio.rainsrc/fixed-spread.rainsrc/dynamic-spread.rainregistrysrc/fixed-limit.rain
📚 Learning: 2025-06-19T03:59:46.063Z
Learnt from: Siddharth2207
Repo: rainlanguage/rain.strategies PR: 42
File: src/fixed-limit.rain:19-23
Timestamp: 2025-06-19T03:59:46.063Z
Learning: In rain.strategies configuration files, `arbitrum2` is an intentional alias for the Arbitrum network (same chain-id 42161) but with updated contract addresses. It serves as a deployment target for newer contract versions while maintaining the existing `arbitrum` configuration during transition periods.
Applied to files:
src/dynamic-spread.rainregistrysrc/fixed-limit.rain
📚 Learning: 2025-07-26T15:31:37.916Z
Learnt from: 0xgleb
Repo: rainlanguage/rain.strategies PR: 45
File: registry:0-0
Timestamp: 2025-07-26T15:31:37.916Z
Learning: In the rain.strategies repository, the registry file uses full commit SHAs to pin strategy URLs as the current established pattern, rather than using tags or branches, as confirmed by project maintainer 0xgleb.
Applied to files:
registry
📚 Learning: 2025-07-03T09:47:48.019Z
Learnt from: thedavidmeister
Repo: rainlanguage/rain.strategies PR: 28
File: src/folio.rain:28-42
Timestamp: 2025-07-03T09:47:48.019Z
Learning: In Rain language strategy files, thedavidmeister prefers intentionally oversimplified setups over complex validation logic, especially in initial implementations like the folio strategy configuration.
Applied to files:
registry
📚 Learning: 2025-09-04T12:59:34.219Z
Learnt from: thedavidmeister
Repo: rainlanguage/rain.strategies PR: 60
File: src/dynamic-spread.rain:924-929
Timestamp: 2025-09-04T12:59:34.219Z
Learning: In the Rain Strategies dynamic spread system, the io values cannot be zero due to business logic constraints where baseline uses any(cost-basis-io last-io) and cost-basis-multiplier is positive, making division-by-zero in inv(stored-last-io) mathematically impossible under normal operation.
Applied to files:
registry
📚 Learning: 2025-07-03T09:47:14.894Z
Learnt from: thedavidmeister
Repo: rainlanguage/rain.strategies PR: 28
File: src/folio.rain:115-122
Timestamp: 2025-07-03T09:47:14.894Z
Learning: In Rain language folio strategy, the zero balance check using `every(input-vault-before() output-vault-before())` is specifically implemented to prevent trades from executing while users are depositing or withdrawing from vaults, serving as a safety mechanism against race conditions during vault operations.
Applied to files:
registry
🔇 Additional comments (8)
settings.yaml (2)
46-46: Subgraph URL update looks correct.The subgraph URL has been updated to reflect the new V6 deployment timestamp.
67-72: Verify whether the address 0x77Ca4947dce161e122Eb690D475448f092a7d7EB is the correct V6 orderbook contract for Base.The Base orderbook address is used consistently across all strategy files (folio.rain, fixed-limit.rain, fixed-spread.rain, dynamic-spread.rain, claims.rain, auction-dca.rain), suggesting this was an intentional systematic deployment. However, if the PR description specifies a different address (0xFe2411CDa193D9E4e83A5c234C7Fd320101883aC), confirm whether the code matches the intended deployment or if the address needs to be updated across all files. The other address mentioned appears only in comments.
The deployment-block value is a temporary configuration detail and can be addressed as part of the broader contract address updates during deployment.
src/dynamic-spread.rain (1)
145-148: Base orderbook address updated consistently with other files.The address change is consistent with the update in
settings.yaml. As noted earlier, please verify this is the correct V6 address and whether thedeployment-blockneeds updating for the new contract.src/fixed-limit.rain (1)
73-76: Base orderbook address updated consistently.The change aligns with the updates in
settings.yamland other strategy files.src/fixed-spread.rain (1)
20-24: Base orderbook address updated consistently.The change is consistent with all other files in this PR.
src/folio.rain (1)
22-22: Address update is consistent with other files.The Base orderbook address matches the update in
src/claims.rain. The same verification concern applies regarding the discrepancy with the PR description's stated address.src/auction-dca.rain (1)
68-68: Address update is consistent across all strategy files.The Base orderbook address matches the updates in
src/claims.rainandsrc/folio.rain. Assuming the address discrepancy with the PR description is resolved, this change is correct.src/claims.rain (1)
22-22: No action needed. The Base orderbook address0x77Ca4947dce161e122Eb690D475448f092a7d7EBat line 22 is consistent across all strategy files and matches the configuration in settings.yaml. The address0xFe2411CDa193D9E4e83A5c234C7Fd320101883aCappears only in comments for raindex-subparser configuration and is not the orderbook address.Likely an incorrect or invalid review comment.
- Address: 0x498Ff70C5f67e63e53b74551DE31387cf2813986 - Deployment block: 41134692 - Subgraph: ob4-base/2026-01-22-c13a
Motivation
Update orderbook contract addresses to V6 across all networks.
Closes #73
Solution
Updated Base network orderbook address from
0x52CEB8eBEf648744fFDDE89F7Bc9C3aC35944775to0xFe2411CDa193D9E4e83A5c234C7Fd320101883aCin:settings.yamlsrc/folio.rainsrc/fixed-limit.rainsrc/claims.rainsrc/fixed-spread.rainsrc/auction-dca.rainsrc/dynamic-spread.rainChecks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.