Skip to content

Update fixed limit#79

Open
Siddharth2207 wants to merge 6 commits intomainfrom
2026-02-03-fl
Open

Update fixed limit#79
Siddharth2207 wants to merge 6 commits intomainfrom
2026-02-03-fl

Conversation

@Siddharth2207
Copy link
Copy Markdown
Contributor

@Siddharth2207 Siddharth2207 commented Feb 3, 2026

Motivation

Update fixed limit

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • New Features

    • Added Base network support for the fixed-limit strategy.
  • UI Changes

    • Fixed-limit strategy UI consolidated to a single Base deployment (Arbitrum and Polygon variants removed).
  • Chores

    • Registry entries and strategy sources migrated to the updated commit across deployments and GUIs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 3, 2026

Walkthrough

Registry entries migrated from commit fa05db09... to d4859ae3.... Strategy source URLs in settings updated. src/fixed-limit.rain consolidated: replaced network-specific entries with a single base orderbook/deployer and removed polygon/Arbitrum-specific orders, scenarios, deployments, and GUI entries.

Changes

Cohort / File(s) Summary
Registry / settings
registry, settings.yaml, .../strategy/*
Updated registry entries and strategy source URLs to point to commit d4859ae346878a375b9cc4cfe3f878000fd8c3b3 for multiple strategies (fixed-limit, auction-dca, grid, dynamic-spread, canary, claims, fixed-spread, folio).
Fixed-limit config
src/fixed-limit.rain
Consolidated network-specific entries into a single base entry: added orderbooks.base (network: base, address 0x498Ff70C5f67e63e53b74551DE31387cf2813986, deployment-block 41134692) and deployers.base (network: base, address 0xd905B56949284Bb1d28eeFC05be78Af69cCf3668); removed polygon/Arbitrum-specific orders, scenarios, deployments, and GUI deployments.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

webapp

Suggested reviewers

  • hardyjosh
  • 0xgleb
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update fixed limit' is vague and does not convey what specific changes were made or why. It lacks meaningful detail about the actual scope of changes. Provide a more specific title that explains the primary change, such as 'Migrate fixed-limit strategy to base network' or 'Consolidate fixed-limit deployments to base network only'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 2026-02-03-fl

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/fixed-limit.rain`:
- Around line 18-20: The YAML block starting with the literal "base" is missing
the required colon and the deployer key lacks its colon; update the block so the
top-level mapping reads "base:" (not "base") and ensure the deployer mapping key
is written as "deployer:" (with the trailing colon) so the keys "network",
"address", and "deployer" parse correctly.

Comment thread src/fixed-limit.rain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant