Skip to content

Rename gui to builder across all strats#89

Open
findolor wants to merge 2 commits intomainfrom
rename-gui-to-builder
Open

Rename gui to builder across all strats#89
findolor wants to merge 2 commits intomainfrom
rename-gui-to-builder

Conversation

@findolor
Copy link
Copy Markdown
Contributor

@findolor findolor commented Feb 24, 2026

Dependent PRs

Motivation

The specs are renaming the top-level YAML field gui to builder (see dependent PR). This PR updates all strategy files in this repo to match.

Solution

Replaced the gui: keyword with builder: in all 8 .rain strategy files:

  • auction-dca.rain
  • canary.rain
  • claims.rain
  • dynamic-spread.rain
  • fixed-limit.rain
  • fixed-spread.rain
  • folio.rain
  • grid.rain

No other config or registry changes were needed.

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • Refactor
    • Renamed the top-level configuration section from "gui" to "builder" across strategy configurations; update any custom configs or tools that reference the old key.
  • Chores
    • Updated registry references to point to the refreshed configuration sources.

@findolor findolor self-assigned this Feb 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f4cbd6 and bb80212.

📒 Files selected for processing (1)
  • registry

Walkthrough

Top-level configuration blocks named gui were renamed to builder across multiple Rain files; the registry mappings were updated to new commit references. Structural keys changed, nested content and deployments largely preserved.

Changes

Cohort / File(s) Summary
Rain config key renames
src/auction-dca.rain, src/canary.rain, src/claims.rain, src/dynamic-spread.rain, src/fixed-limit.rain, src/fixed-spread.rain, src/folio.rain, src/grid.rain
Replaced top-level gui block with builder in each file. Most files kept the same nested fields; src/folio.rain additionally moved previously top-level deployment details under the new builder.deployments nesting.
Registry updates
registry/settings.yaml, registry/...
Updated registry URL/file mappings to reference a different commit hash for settings and strategy sources (values changed; keys preserved).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly summarizes the main change: renaming 'gui' to 'builder' across strategy files, matching the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rename-gui-to-builder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/folio.rain`:
- Line 35: This change renames the top-level key from gui: to builder: which is
dependent on rainlanguage/specs#46; do not merge until that spec PR is merged,
or make the change backward-compatible by including both keys (keep gui:
alongside builder: in src/folio.rain) or add feature-gating logic so tools
expecting gui: still find the data; reference the renamed symbol builder: and
the original gui: when implementing the compatibility or gating so the
parser/toolchain continues to accept files until specs#46 is merged.

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3da2d7 and 7f4cbd6.

📒 Files selected for processing (8)
  • src/auction-dca.rain
  • src/canary.rain
  • src/claims.rain
  • src/dynamic-spread.rain
  • src/fixed-limit.rain
  • src/fixed-spread.rain
  • src/folio.rain
  • src/grid.rain

Comment thread src/folio.rain
scenario: base

gui:
builder:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

rainlanguage specs pull request 46 merged status builder gui

💡 Result:

Pull request rainlanguage/specs #46 is titled “rename gui to builder” and is currently Open (not merged) (as of Feb 23, 2026 on the PR page). It proposes documentation/spec updates to rename the top-level YAML field gui to builder, rename gui.mdbuilder.md, and update references in ob-yaml.md and metadata-v1.md. [1]


Do not merge until rainlanguage/specs#46 is merged — critical dependency.

The gui:builder: rename is correct, but specs PR #46 is still open. Merging this before the spec changes land will cause the Rain toolchain to reject all strategy files, as the parser will expect gui: per the current spec. This is a hard blocker: confirm specs#46 is merged first.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/folio.rain` at line 35, This change renames the top-level key from gui:
to builder: which is dependent on rainlanguage/specs#46; do not merge until that
spec PR is merged, or make the change backward-compatible by including both keys
(keep gui: alongside builder: in src/folio.rain) or add feature-gating logic so
tools expecting gui: still find the data; reference the renamed symbol builder:
and the original gui: when implementing the compatibility or gating so the
parser/toolchain continues to accept files until specs#46 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant